Changes to keystone_service doesn't trigger a refresh of keystone_endpoint

[Mark Chappell]

When making changes to both the service and the endpoint, you can trigger an error if the services have already been prefetched:

Notice: Compiled catalog for overcloud-controller-0.localdomain in environment production in 0.42 seconds
Notice: /Stage[main]/Main/Keystone::Resource::Service_identity[keystone]/Keystone_endpoint[RegionOne/keystone]/ensure: created
Notice: /Stage[main]/Main/Keystone::Resource::Service_identity[heat]/Keystone_service[heat]/description: description changed 'Openstack Orchestration Service' to 'Openstack Orchestration'
Notice: /Stage[main]/Main/Keystone::Resource::Service_identity[heat]/Keystone_endpoint[RegionOne/heat]/public_url: public_url changed 'http://10.27.53.111:8004/v1/%(tenant_id)s' to 'http://10.27.53.111:8004/v1/%(tenant_id)s/'
Notice: /Stage[main]/Main/Keystone::Resource::Service_identity[heat]/Keystone_endpoint[RegionOne/heat]/internal_url: internal_url changed 'http://10.27.50.112:8004/v1/%(tenant_id)s' to 'http://10.27.50.112:8004/v1/%(tenant_id)s/'
Notice: /Stage[main]/Main/Keystone::Resource::Service_identity[heat]/Keystone_endpoint[RegionOne/heat]/admin_url: admin_url changed 'http://10.27.50.112:8004/v1/%(tenant_id)s' to 'http://10.27.50.112:8004/v1/%(tenant_id)s/'
Error: /Stage[main]/Main/Keystone::Resource::Service_identity[heat]/Keystone_endpoint[RegionOne/heat]: Could not evaluate: Execution of '/bin/openstack endpoint delete 7b90ec01cd8746fb817efd33ff0666d3' returned 1: ERROR: openstack Could not find endpoint: 7b90ec01cd8746fb817efd33ff0666d3 (HTTP 404) (Request-ID: req-5eda695c-fdeb-4534-858a-452d3e335d17)
Notice: Finished catalog run in 9.46 seconds

This only occurs if another service has already triggered a prefetch:

keystone::resource::service_identity { 'keystone':
  configure_user => false,
  configure_user_role => false,
  service_type => 'identity',
  service_description => 'OpenStack Identity Service',
  public_url => 'http://10.27.53.111:5000/v2.0',
  admin_url => 'http://192.0.2.23:35357/v2.0',
  internal_url => 'http://10.27.50.112:5000/v2.0',
  region => 'RegionOne',
} ->

# Service Description and Endpoint URLs have previously be set differently
keystone::resource::service_identity { 'heat':
  configure_user => true,
  configure_user_role => true,
  configure_endpoint => true,
  configure_service => true,
  service_type => 'orchestration',
  service_description => 'Openstack Orchestration',
  service_name => 'heat',
  region => 'RegionOne',
  password => 'my_password',
  email => 'heat@localhost',
  tenant => 'service',
  public_url => 'http://10.27.53.111:8004/v1/%(tenant_id)s',
  admin_url => 'http://10.27.50.112:8004/v1/%(tenant_id)s',
  internal_url => 'http://10.27.50.112:8004/v1/%(tenant_id)s',
}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/243596

[Matt Fischer (mfisch)]

Only affects kilo per commit message.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/243596
Reason: This review is > 4 weeks without comment or failed Jenkins or merge conflict the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.