test_connect_volume fails

[Walt Boring]

When the unit tests are run on a system that has a live /dev/disk/by-path some of the tests fail.

They currently are decorated with a @testtools.skipUnless(os.path.exists('/dev/disk/by-path'),
which causes them to not run on most systems.

The expected_commands that are tested in _test_connect_volume are incorrect for non multipath enabled systems and hence cause a failure.

The fix is simply to remove the 2 rescan commands that only happen when the brick connector is configured with multipath=True

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/243338
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=62b01e9b8137419e2c80ec808af9a36ce8840277
Submitter: Jenkins
Branch: master

commit 62b01e9b8137419e2c80ec808af9a36ce8840277
Author: Walter A. Boring IV <email address hidden>
Date: Mon Nov 9 13:53:53 2015 -0800

    Fix test_connect_volume when skip is bypassed

    If you run the unit tests with a live /dev/disk/by-path
    on the system, the tests fall through the skipUnless
    decorators. This exposed some failures in the expected
    commands, which were incorrect. The expected commands
    in _test_connect_volume had assumed the multipath set of
    commands which included a rescan.

    This patch removes the rescan expected tests, as those
    are only run for multipath related attaches.

    Closes-Bug: #1514611
    Change-Id: If2e77af2a63c33df2f190f77b6ba4cea0bc31b31

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/os-brick 0.6.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/264317

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/264317
Committed: https://git.openstack.org/cgit/openstack/os-brick/commit/?id=00be786e9bc401f784cf52528376c6f95ad851f4
Submitter: Jenkins
Branch: master

commit 00be786e9bc401f784cf52528376c6f95ad851f4
Author: Walter A. Boring IV <email address hidden>
Date: Wed Jan 6 03:22:15 2016 -0800

    Fix another unit test failure

    There was another unit test that was failing when
    /dev/disk/by-path exists on the system, due to a missing
    expected scsi_id command.

    This is another follow up fix as well as :
    https://review.openstack.org/#/c/243338/

    Change-Id: I7fb3a9bd035dbd9add496868d2c9da91f30c01fd
    Closes-Bug: #1514611

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/os-brick 0.8.0 release.