Too many oslo_messaging warnings using wait() after start()

Bug #1514459 reported by Lingxian Kong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Medium
Lingxian Kong

Bug Description

When start mistral service using CLI, we will see a lot of oslo_messaging warnings like the following:
......
2015-11-09 22:05:02.996 29405 WARNING oslo_messaging.server [-] wait() should be called after stop() as it waits for existing messages to finish processing
2015-11-09 22:05:02.997 29405 WARNING oslo_messaging.server [-] wait() should be called after stop() as it waits for existing messages to finish processing
2015-11-09 22:05:03.996 29405 WARNING oslo_messaging.server [-] wait() should have been called after stop() as wait() waits for existing messages to finish processing, it has been 1.00 seconds and stop() still has not been called
2015-11-09 22:05:03.997 29405 WARNING oslo_messaging.server [-] wait() should have been called after stop() as wait() waits for existing messages to finish processing, it has been 1.00 seconds and stop() still has not been called
......

According to http://docs.openstack.org/developer/oslo.messaging/notification_listener.html, the correct usage is to call stop() before wait(), so in mistral case, we should never call stop() and wait() in initialization of engine and executor service.

Lingxian Kong (kong)
Changed in mistral:
assignee: nobody → Lingxian Kong (kong)
milestone: none → mitaka-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/243146

Changed in mistral:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/243146
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=ec28a305d91139ef5d307fa56ad289a635e37a90
Submitter: Jenkins
Branch: master

commit ec28a305d91139ef5d307fa56ad289a635e37a90
Author: Lingxian Kong <email address hidden>
Date: Mon Nov 9 22:47:29 2015 +0800

    Removing wait() when initializing notification listener

    According to [1],the correct usage is to call stop() before wait(), so in
    mistral case, we should never call stop() and wait() in initialization of
    engine and executor service.

    [1]:
    http://docs.openstack.org/developer/oslo.messaging/notification_listener.html

    Change-Id: Ic6a802bff35a6a6fdfadf38474782efd12fd34d8
    Closes-Bug: #1514459

Changed in mistral:
status: In Progress → Fix Committed
Changed in mistral:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/249593

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/liberty)

Reviewed: https://review.openstack.org/249593
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=73d783eb90676a42a59495246d316421417ea2e1
Submitter: Jenkins
Branch: stable/liberty

commit 73d783eb90676a42a59495246d316421417ea2e1
Author: Lingxian Kong <email address hidden>
Date: Mon Nov 9 22:47:29 2015 +0800

    Removing wait() when initializing notification listener

    According to [1],the correct usage is to call stop() before wait(), so in
    mistral case, we should never call stop() and wait() in initialization of
    engine and executor service.

    [1]:
    http://docs.openstack.org/developer/oslo.messaging/notification_listener.html

    Change-Id: Ic6a802bff35a6a6fdfadf38474782efd12fd34d8
    Closes-Bug: #1514459
    (cherry picked from commit ec28a305d91139ef5d307fa56ad289a635e37a90)

tags: added: in-stable-liberty
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/mistral 2.0.0.0b1

This issue was fixed in the openstack/mistral 2.0.0.0b1 development milestone.

Changed in mistral:
status: Fix Committed → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/mistral 1.0.1

This issue was fixed in the openstack/mistral 1.0.1 release.

Changed in mistral:
milestone: mitaka-1 → 2.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/mistral 1.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.