TypeError Exception during attemt to set some resource's parameter from `null` to some value

Bug #1514364 reported by Dmytro Dovbii
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Liyingjun

Bug Description

Create murano-app workflow which updates stack template. Choose some parameter which was set to `null`.

for example:

...
# use base class of Instance
- $.instance.deploy()
- $template:
     resources:
       $.instance.name:
         type: 'OS::Nova::Server'
           properties:
             user_data: 'aaaa' # was `null`
- $environment: $.find(std:Environment).require()
- $environment.stack.updateTemplate($template)
- $environment.stack.push()

...

You will get TypeError() exception.

We need to modificate logic here to allow user modifcate 'null'-parameters:

https://github.com/openstack/murano/blob/master/murano/dsl/helpers.py#L84-L96

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/243088

Changed in murano:
assignee: nobody → Liyingjun (liyingjun)
status: New → In Progress
Changed in murano:
importance: Undecided → Medium
milestone: none → mitaka-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/243088
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=b8fa64b8a254fe4e4a994cae704ee49ff71b6174
Submitter: Jenkins
Branch: master

commit b8fa64b8a254fe4e4a994cae704ee49ff71b6174
Author: liyingjun <email address hidden>
Date: Mon Nov 9 21:02:21 2015 +0800

    Fix TypeError set param from 'null' to some value

    TypeError Exception during attemt to set some resource's parameter from
    `null` to some value or value to `null`.

    Change-Id: Ib20218f6a8676669230f440a4a13dea61f2d4c6b
    Closes-bug: #1514364

Changed in murano:
status: In Progress → Fix Committed
Changed in murano:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.