Dollar signs in swift backend passwords causes errors

Bug #1514291 reported by Major Hayden
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Low
Major Hayden
Kilo
Fix Released
Low
Major Hayden
Liberty
Fix Released
Low
Major Hayden
Trunk
Fix Released
Low
Major Hayden

Bug Description

If a deployer chooses to use a swift backend for glance that uses a dollar sign ($) in the password, the authentication attempt from glance to the swift backend will fail. This is due to the way that oslo.config formats strings from configuration files. This bug has more details:

  https://bugs.launchpad.net/oslo-incubator/+bug/1259729

The proper way to escape is to add an additional dollar sign, but this isn't well documented within oslo.config or openstack-ansible.

Changed in openstack-ansible:
assignee: nobody → Major Hayden (rackerhacker)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/242918

Changed in openstack-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (master)

Reviewed: https://review.openstack.org/242918
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=1f4996bdd93914b9533c1e9931aca92d1ae56295
Submitter: Jenkins
Branch: master

commit 1f4996bdd93914b9533c1e9931aca92d1ae56295
Author: Major Hayden <email address hidden>
Date: Sun Nov 8 21:47:54 2015 -0600

    Adding docs/comments for glance config

    Deployers who use a dollar sign ($) in their swift backend passwords for glance
    will be unable to authenticate to the swift backend. This is due to how
    oslo.config formats strings. This patch adds documentation and comments to
    the user_variables.yml to ensure deployers know how to escape those strings.

    This patch also adds a commented variable for the auth version on swift
    backends so that deployers are reminded to use the correct version number.

    Closes-bug: 1514291

    Change-Id: I717e9afb5af1160de67dc5d0f87985fde5ad393e

Changed in openstack-ansible:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (liberty)

Fix proposed to branch: liberty
Review: https://review.openstack.org/243651

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (kilo)

Fix proposed to branch: kilo
Review: https://review.openstack.org/243661

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (kilo)

Reviewed: https://review.openstack.org/243661
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=ac3540f5ee20d23b3bbd2d9f1fc67b298505914b
Submitter: Jenkins
Branch: kilo

commit ac3540f5ee20d23b3bbd2d9f1fc67b298505914b
Author: Major Hayden <email address hidden>
Date: Sun Nov 8 21:47:54 2015 -0600

    Adding docs/comments for glance config

    Deployers who use a dollar sign ($) in their swift backend passwords for glance
    will be unable to authenticate to the swift backend. This is due to how
    oslo.config formats strings. This patch adds documentation and comments to
    the user_variables.yml to ensure deployers know how to escape those strings.

    This patch also adds a commented variable for the auth version on swift
    backends so that deployers are reminded to use the correct version number.

    Closes-bug: 1514291

    Change-Id: I717e9afb5af1160de67dc5d0f87985fde5ad393e
    (cherry picked from commit 1f4996bdd93914b9533c1e9931aca92d1ae56295)

tags: added: in-kilo
tags: added: in-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (liberty)

Reviewed: https://review.openstack.org/243651
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=871f6efd150892e6780423820ba8c070d233a28d
Submitter: Jenkins
Branch: liberty

commit 871f6efd150892e6780423820ba8c070d233a28d
Author: Major Hayden <email address hidden>
Date: Sun Nov 8 21:47:54 2015 -0600

    Adding docs/comments for glance config

    Deployers who use a dollar sign ($) in their swift backend passwords for glance
    will be unable to authenticate to the swift backend. This is due to how
    oslo.config formats strings. This patch adds documentation and comments to
    the user_variables.yml to ensure deployers know how to escape those strings.

    This patch also adds a commented variable for the auth version on swift
    backends so that deployers are reminded to use the correct version number.

    Closes-bug: 1514291

    Change-Id: I717e9afb5af1160de67dc5d0f87985fde5ad393e
    (cherry picked from commit 1f4996bdd93914b9533c1e9931aca92d1ae56295)

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 13.0.0

This issue was fixed in the openstack/openstack-ansible 13.0.0 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 12.0.11

This issue was fixed in the openstack/openstack-ansible 12.0.11 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.14

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 11.2.15

This issue was fixed in the openstack/openstack-ansible 11.2.15 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.