Claw's LPIA build is not enabling the hildon interface

[Adilson Oliveira]

Binary package hint: claws-mail

The resulting LPIA package has the usual GTK interface. This is caused by wrong check of the hildon-fm-2 library.

[Adilson Oliveira (agoliveira)]

This patch should take care of the problem and, additionally, a different flag, USE_HILDON was created to separate the changes created for Maemo that does not go into UME like the TAP_AND_HOLD functions for GTK that are not upstream yet.

[Daniel Holbach (dholbach)]

The configure.ac change should be in a different patch.
daniel@bert:~/claws-mail-2.10.0$ diffstat debian/patches/02_autoconf_patch
 configure | 175 +++++++++++++++++++++++++++++++++++++++++++++++------------
 configure.ac | 21 ++++++-
 2 files changed, 159 insertions(+), 37 deletions(-)
daniel@bert:~/claws-mail-2.10.0$

This should be debian/rules, right?
  * debian/control
    - Changed --enable-maemo to --enable-hildon when compiled for lpia.

Why do you change the ifeq ($(DEB_BUILD_ARCH), lpia) test in debian/rules like that? You could simply list the things that differ there. It makes it much easier to understand.

Are these all meant to be
 - not with Hildon: --enable-ldap --enable-openssl --enable-gpgme --enable-ipv6 --enable-jpilot
 - noted down in both: --enable-spamassassin-plugin=yes
 - just with Hildon: --disable-manual --disable-libetpan --disable-compface

[Adilson Oliveira (agoliveira)]

The change in the test in debian/rules was done because there is 3 possibilities:
- Normal compilation (i386)
- Maemo compilation (explicity using the flag --enable-maemo, not covered on debian/rules)
- LPIA compilation, our case that enables the hildon interface (--enable-hildon) without using some changes applied by the previous situation (Maemo)
So, yes, it should be refined listing only the differences (my mistake not do it) but the test hast to be there.
I'll fix the problems you pointed, thanks.

[Cesare Tirabassi (norsetto)]

Unsubscribing u-u-s, please subscribe again when patch is corrected.
Thanks for your work.

[Adilson Oliveira (agoliveira)]

I hope this patch is ok now. I also took some time to enable the plugins that were disabled when built for lpia.

[Adilson Oliveira (agoliveira)]

BTW Daniel, this debian/patches/02_autoconf_patch is (already uploaded) and I don't think I should change it, right?

[Daniel Holbach (dholbach)]

No problem to change the autoconf patch - it will be much easier to regenerate it every time it needs to be.

[Adilson Oliveira (agoliveira)]

Can someone please take a look at this? It's necessary to UME. Thanks.

[Cesare Tirabassi (norsetto)]

I'm right now merging the new version (claws-mail-3.0.2) from debian unstable.
I think it will be much better if you can prepare a patch for this version.

[Loïc Minier (lool)]

@Cesare: did you push the new Claws already? Hardy seems to still be at 2.10.

[Cesare Tirabassi (norsetto)]

@Loic,
Not yet. We could sync directly but for the hildon changes, thats why I asked Adilson what he wants to do with those. I understand some are obsolete, and some others we need to change, but we need his input.
If there is a time pressure, we can sync from Debian 3.0.2 and later on make whatever changes we need to make to enable the hildon interface.

[Adilson Oliveira (agoliveira)]

Sorry for the delay but we are at the UDS and I forgot about it. Anyway, if you sync with upstream we certainly will have a lot of breakage ahead but just do it removing the hildon patches and I'll fix them later if necessary as we actually are not sure if we will keep claws as our email client of choice for UME.

[Cesare Tirabassi (norsetto)]

OK, I have filed a sync request here:

https://bugs.launchpad.net/ubuntu/+source/claws-mail/+bug/159071

I will keep this bug report as "in-progress" for the time being. Please report here if any change is needed to enable the hildon interface.

Thanks.