Ubuntu Document Viewer App

[doc viewer] Slide navigation buttons obscured by bottom edge tab

Bug #1513843 reported by Alan Pope 🍺🐧🐱 🦄
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Document Viewer App
Fix Released
Undecided
Stefano Verzegnassi
Ubuntu UX
Fix Released
High
James Mulholland

Bug Description

Open a presentation with docviewer and notice the bottom edge swipe tab obscures the buttons for previous/next slide.

See screenshot.

Need design input to figure where these controls might be better placed.

UX Comment:
Just tested Stefano's solution out on device and it works very nicely.

See original description
Tags: loviewer

Related branches

lp:~verzegnassi-stefano/ubuntu-docviewer-app/reboot-uitk13
Roman Shchekin: Approve
Jenkins Bot: Approve (continuous-integration)
Diff: 2460 lines (+798/-709)
47 files modified
debian/control (+1/-1)
po/com.ubuntu.docviewer.pot (+33/-76)
src/app/qml/common/CommandLineProxy.qml (+2/-2)
src/app/qml/common/DetailsPage.qml (+1/-1)
src/app/qml/common/EmptyState.qml (+2/-2)
src/app/qml/common/ErrorDialog.qml (+2/-2)
src/app/qml/common/HorizontalDivider.qml (+28/-0)
src/app/qml/common/PageWithBottomEdge.qml (+33/-43)
src/app/qml/common/PickImportedDialog.qml (+2/-2)
src/app/qml/common/RejectedImportDialog.qml (+2/-2)
src/app/qml/common/ResizeableSidebar.qml (+98/-0)
src/app/qml/common/SubtitledListItem.qml (+2/-2)
src/app/qml/common/TextFieldButtonPopover.qml (+58/-0)
src/app/qml/common/TextFieldWithButton.qml (+84/-0)
src/app/qml/common/UnknownTypeDialog.qml (+2/-2)
src/app/qml/common/VerticalDivider.qml (+35/-0)
src/app/qml/documentPage/DeleteFileDialog.qml (+2/-2)
src/app/qml/documentPage/DocumentDelegateActions.qml (+2/-2)
src/app/qml/documentPage/DocumentEmptyState.qml (+1/-1)
src/app/qml/documentPage/DocumentListDelegate.qml (+3/-3)
src/app/qml/documentPage/DocumentListView.qml (+1/-3)
src/app/qml/documentPage/DocumentPage.qml (+2/-2)
src/app/qml/documentPage/DocumentPageDefaultHeader.qml (+2/-2)
src/app/qml/documentPage/DocumentPagePickModeHeader.qml (+1/-1)
src/app/qml/documentPage/DocumentPageSearchHeader.qml (+1/-1)
src/app/qml/documentPage/DocumentPageSelectionModeHeader.qml (+2/-4)
src/app/qml/documentPage/SearchEmptyState.qml (+1/-1)
src/app/qml/documentPage/SectionHeader.qml (+2/-2)
src/app/qml/documentPage/SharePage.qml (+1/-1)
src/app/qml/documentPage/SortSettingsDialog.qml (+2/-2)
src/app/qml/loView/LOViewDefaultHeader.qml (+31/-30)
src/app/qml/loView/LOViewGotoDialog.qml (+2/-2)
src/app/qml/loView/LOViewPage.qml (+39/-95)
src/app/qml/loView/LOViewZoomHeader.qml (+0/-59)
src/app/qml/loView/PanelButton.qml (+1/-1)
src/app/qml/loView/PartsView.qml (+112/-58)
src/app/qml/loView/SlideControllerPanel.qml (+0/-87)
src/app/qml/loView/ZoomSelector.qml (+129/-114)
src/app/qml/pdfView/PdfContentsPage.qml (+3/-8)
src/app/qml/pdfView/PdfView.qml (+28/-19)
src/app/qml/pdfView/PdfViewDefaultHeader.qml (+5/-19)
src/app/qml/pdfView/PdfViewDelegate.qml (+1/-1)
src/app/qml/pdfView/PdfViewGotoDialog.qml (+2/-2)
src/app/qml/textView/TextView.qml (+3/-3)
src/app/qml/textView/TextViewDefaultHeader.qml (+5/-19)
src/app/qml/ubuntu-docviewer-app.qml (+14/-29)
src/plugin/libreofficetoolkit-qml-plugin/qml/Viewer.qml (+15/-1)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :
James Mulholland (jamesmulholland)
Changed in ubuntu-ux:
assignee: nobody → James Mulholland (jamesjosephmulholland)
Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

Heya guys,

I've already committed a fix for this in one of the development branch[1] we have to merge.

I've attached a screenshot with the implemented solution. Let me know if it looks okay or it needs some further change.

[1] revision n°210, https://code.launchpad.net/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-uitk13

Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

Sorry, I forgot to specify what the changes are about:

* Removed the bottom edge and the panel with the buttons
* Added a list view (which can not be hidden) with an horizontal orientation, which show a thumbnail and the number of slide.
   The height of the list view is 12gu.
* On wider screen (width > 120gu), the list view is replaced by the left sidebar as we've already seen in the earlier implementations of the LibreOffice viewer.

Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

That looks excellent! Nice work!

This is separate from a 'full screen' option, right?

Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

Yes, this is not related to the 'full screen' mode.

The 'full screen' mode will probably be provided through a different Ubuntu.Page, which will include a Image component which fills the whole page and re-uses the code logic of the LibreOffice thumbnailer.

That way we don't have to handle the Ubuntu.Layouts stuff and anything else (e.g. unneccessary Flickables, zooming, page headers, and so on).

Most part of the code is already there, since basically all we have to do is to show bigger thumbnails. We probably still need to shape some exceptions that we could meet when running that code in a different scenario, and to think how to provide touch/mouse controls in 'full screen' mode.

Stefano Verzegnassi (verzegnassi-stefano)
Changed in ubuntu-docviewer-app:
assignee: nobody → Stefano Verzegnassi (verzegnassi-stefano)
status: New → In Progress
Magdalena Mirowicz (magdalena-mirowicz)
summary: - Slide navigation buttons obscured by bottom edge tab
+ [doc viewer] Slide navigation buttons obscured by bottom edge tab
Magdalena Mirowicz (magdalena-mirowicz)
Changed in ubuntu-ux:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

Fix committed into lp:ubuntu-docviewer-app at revision 210, scheduled for release in ubuntu-docviewer-app, milestone Unknown

Changed in ubuntu-docviewer-app:
status: In Progress → Fix Committed
Stefano Verzegnassi (verzegnassi-stefano)
Changed in ubuntu-docviewer-app:
status: Fix Committed → Fix Released
James Mulholland (jamesmulholland)
Changed in ubuntu-ux:
status: Triaged → Fix Released
description: updated
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.