Can not save IP range with 1 address for networks

[Julia Aranovich]

Steps to reproduce:

1. create default env
2. go to Networks and try to save an IP range included 1 address only for public network (let it be 172.16.0.2 - 172.16.0.2)

Expected result: the change is saved succesfully.
Actual result: PUT /api/clusters/x/network_configuration/neutron returns 400 Bad request. The tab is locked on UI. No errors on UI, user doesn't have any information what is going on and why data was not saved.

Proposed solution: allow to save IP range with 1 address in Nailgun

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/242426

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/242426
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=83a448c36a8120bd97795f73d810afb125ad7643
Submitter: Jenkins
Branch: master

commit 83a448c36a8120bd97795f73d810afb125ad7643
Author: Ivan Kliuk <email address hidden>
Date: Wed Nov 4 06:55:07 2015 +0200

    Allow IP addresses in IP ranges to be equal

    * Update JSON-schema 'base_types.IP_ADDRESS_RANGE' to allow non-unique items.
    * Add corresponding unit tests.

    Change-Id: I0d9bfb11c0fa69874223ea451ee49f473040ba53
    Closes-bug: #1513774

[Anastasia Palkina (apalkina)]

I tried to save such Public range settings.
But this action has failed again (see screen)

In Firebug Console:
500 Internal Server Error.
Not enough free IP addresses in ranges [172.16.0.2-172.16.0.2] of 'public' network

"release_versions": {"2015.1.0-8.0": {"VERSION": {"fuel-upgrade_sha": "1e894e26d4e1423a9b0d66abd6a79505f4175ff6", "fuel-createmirror_sha": "0494bcb342e3ab7b1e0612998552f1414af916f3", "shotgun_sha": "25dd78a3118267e3616df0727ce746e7dead2d67", "api": "1.0", "fuelmain_sha": "b5eb33ca7147dfda7a943a7f8f58c28e86d63992", "astute_sha": "959b06c5ef8143125efd1727d350c050a922eb12", "fuel-ostf_sha": "f169d495691ea3d40d3d6d0278265698d3f6ed14", "openstack_version": "2015.1.0-8.0", "build_id": "149", "fuelmenu_sha": "c1493ce35773f13055359cfabc589487044ee71e", "build_number": "149", "fuel-library_sha": "0040ee690445ed89cfab2a02ba865297c2a312c8", "fuel-nailgun-agent_sha": "00b4b11553c250f22c0079fb74c8b782dcb7b740", "fuel-nailgun_sha": "35dda0f36c4c5e52bc68492ab7ad154d14747eef", "fuel-agent_sha": "07560a9fc3ce5301ace04d2d3e5d68db6ee4f8d5", "production": "docker", "network-checker_sha": "a57e1d69acb5e765eb22cab0251c589cd76f51da", "feature_groups": ["mirantis"], "release": "8.0", "python-fuelclient_sha": "e685d68c1c0d0fa0491a250f07d9c3a8d0f9608c"}}}, "fuel-upgrade_sha": "1e894e26d4e1423a9b0d66abd6a79505f4175ff6", "fuel-createmirror_sha": "0494bcb342e3ab7b1e0612998552f1414af916f3", "shotgun_sha": "25dd78a3118267e3616df0727ce746e7dead2d67", "api": "1.0", "fuelmain_sha": "b5eb33ca7147dfda7a943a7f8f58c28e86d63992", "astute_sha": "959b06c5ef8143125efd1727d350c050a922eb12", "fuel-ostf_sha": "f169d495691ea3d40d3d6d0278265698d3f6ed14", "openstack_version": "2015.1.0-8.0", "build_id": "149", "fuelmenu_sha": "c1493ce35773f13055359cfabc589487044ee71e", "build_number": "149", "auth_required": true, "fuel-library_sha": "0040ee690445ed89cfab2a02ba865297c2a312c8", "fuel-nailgun-agent_sha": "00b4b11553c250f22c0079fb74c8b782dcb7b740", "fuel-nailgun_sha": "35dda0f36c4c5e52bc68492ab7ad154d14747eef", "fuel-agent_sha": "07560a9fc3ce5301ace04d2d3e5d68db6ee4f8d5", "production": "docker", "network-checker_sha": "a57e1d69acb5e765eb22cab0251c589cd76f51da", "feature_groups": ["mirantis"], "release": "8.0", "python-fuelclient_sha": "e685d68c1c0d0fa0491a250f07d9c3a8d0f9608c"

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/244646

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/244646
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=1d70ec7df5a23b32252fef698907125abe724630
Submitter: Jenkins
Branch: master

commit 1d70ec7df5a23b32252fef698907125abe724630
Author: Ivan Kliuk <email address hidden>
Date: Fri Nov 6 15:28:09 2015 +0200

    Network configuration update should return 400

    In case of raising exception 'OutOfIPs' Nailgun should return 400 error.

    * Add exception catching for 'errors.OutOfIPs' in 'ProviderHandler.PUT'.
    * Add corresponding unit test.

    Change-Id: I7018621350651a351c164fe45a72001874b11e57
    Partial-bug: #1513774

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/246804

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/246804
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=ec5879ca6d677d238938cba6cf1fb75c3e0a15ea
Submitter: Jenkins
Branch: master

commit ec5879ca6d677d238938cba6cf1fb75c3e0a15ea
Author: Ivan Kliuk <email address hidden>
Date: Tue Nov 17 23:53:08 2015 +0200

    Change format of returning message

    * When no free IP addresses are available in public network, Nailgun should
      return error message in a way which is acceptable by Fuel UI.
    * Update corresponding unit test.

    Change-Id: I9a2689c134bb4157d81f0749db495ec66d399118
    Partial-bug: #1513774

[Julia Aranovich (jkirnosova)]

I think this ticket is resolved. The rest problem is that UI doesn't show saving changes error if it is not enough addresses in range. but this will be fixed within https://bugs.launchpad.net/fuel/+bug/1514501

[Dmitry Belyaninov (dbelyaninov)]

Verified on ISO #241.
Environment created by dos.py script
According to network console "400 Bad Request" was received after the trying to save incorrect IP range.
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  openstack_version: "2015.1.0-8.0"
  api: "1.0"
  build_number: "241"
  build_id: "241"
  fuel-nailgun_sha: "f47112b607d88ce55e5379a2356035cbee58b83f"
  python-fuelclient_sha: "91474bd8c526f4f536ab13368feb4a5c1b84d185"
  fuel-agent_sha: "820abc51714e2aa47b77d3f3b8787f41dad85b16"
  fuel-nailgun-agent_sha: "a33a58d378c117c0f509b0e7badc6f0910364154"
  astute_sha: "b60624ee2c5f1d6d805619b6c27965a973508da1"
  fuel-library_sha: "5ce49d7259d16c2fd118088e7795aef99d626812"
  fuel-ostf_sha: "a98973482f839554d90cc1c071d625a01e018cfe"
  fuel-createmirror_sha: "6daaf71bd78120461ae31561aeda777f40ca8653"
  fuelmenu_sha: "fcb15df4fd1a790b17dd78cf675c11c279040941"
  shotgun_sha: "25a0cc461a9fa4f7684f04cef0ff4ad9aa99a64d"
  network-checker_sha: "a3534f8885246afb15609c54f91d3b23d599a5b1"
  fuel-upgrade_sha: "1e894e26d4e1423a9b0d66abd6a79505f4175ff6"
  fuelmain_sha: "da9e5722836d21bf4b93d591c6fddba9f3bcde5e"