Magnum

Properly place import statements in monitors.py

Bug #1513722 reported by bharaththiruveedula
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Undecided
bharaththiruveedula
Magnum mitaka-1

Bug Description

As Hongbin suggested here https://review.openstack.org/#/c/234817/, use importutils to import different COE classes, instead of importing each COE classes at the bottom of the module. The imports are at the bottom, to avoid circular import issue.

See original description
bharaththiruveedula (bharath-ves)
Changed in magnum:
assignee: nobody → bharaththiruveedula (bharath-ves)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/242401

Changed in magnum:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/242401
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=9a2872dea0486c8181c116838f9af591c7cc00a0
Submitter: Jenkins
Branch: master

commit 9a2872dea0486c8181c116838f9af591c7cc00a0
Author: Bharath Thiruveedula <email address hidden>
Date: Fri Nov 6 13:31:54 2015 +0530

    use importutils in monitors.py to avoid cyclic imports

    * Remove import statements from the method level.
    * Use importutils to import COE monitor classes.

    Change-Id: Ie343def2c97f96d6a269ee6030a83b4eaf879c1a
    Closes-Bug: #1513722

Changed in magnum:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.