Unable to load savegame - tribe ... does not define building type

Bug #1513550 reported by Alexey Torkhov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Medium
Unassigned

Bug Description

I was playing r7589 as an empire. After conquering atlanteans enemy, I cannot load autosaves with error message:

buildings: tribe empire does not define building type "atlanteans_guardhouse"

Tags: savegame

Related branches

Revision history for this message
Alexey Torkhov (atorkhov) wrote :
Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for reporting and the savegame :)

My guess is that while loading the game, the building's index is checked for tribe.has_building(). The check needs to get the BuildingDescr and add || descr.type() == MapObjectType::MILITARYSITE to the check.

Revision history for this message
Nasenbaer (nasenbaer) wrote :

Fix committed in rev. 7603

Changed in widelands:
status: New → Fix Committed
milestone: none → build19-rc1
importance: Undecided → Medium
Revision history for this message
Nasenbaer (nasenbaer) wrote :

sorry too fast... had two bugs open and commented the wrong one :-/

Changed in widelands:
status: Fix Committed → Confirmed
Revision history for this message
Nasenbaer (nasenbaer) wrote :

But now it is fixed :).

GunChleoc, you were right with your idea.

Unfortunally the saved game from Alexey is still broken due to bug #1514105 which broke the saved game during writing process.

Changed in widelands:
status: Confirmed → Fix Committed
Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for the fix! I will have a look at the other bug.

tags: added: savegame
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.