fuelmenu save-only mode resets ADMIN_NETWORK settings

[Matthew Mosesohn]

Steps to reproduce
Configure dhcp pool start/end and gateway fields with fuelmenu
Run fuelmenu --save-only --iface=eth0
Compare /etc/fuel/astute.yaml

Expected results:
All previously configured values are retained

Actual Results:
Changes are lost and reset to defaults (based on the IP assigned to eth0)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/242109

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/242109
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=1f1d6e20c7e70bf4adc40508e24f4eb93849420e
Submitter: Jenkins
Branch: master

commit 1f1d6e20c7e70bf4adc40508e24f4eb93849420e
Author: Matthew Mosesohn <email address hidden>
Date: Thu Nov 5 18:12:48 2015 +0300

    Disable --save-only mode during post-deployment

    It is common for users to run bootstrap_admin_node to apply
    a patch to Fuel Master, which has the side effect of calling
    fuelmenu --save-only --iface=ethN. This behavior initializes
    all fields to defaults, which has negative consequences.

    Now fuelmenu --save-only --iface=ethN will result in a message
    saying that the user should run full fuelmenu in order to make
    changes.

    Moved get_deployment_mode to common.utils so it can be called
    from save_only without expensive urwid imports.

    Added unit tests for get_deployment_mode

    Change-Id: I78d3261a5e2700b7533d9873f6bec9cc4e98c362
    Closes-Bug: #1513486

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/243063

[Matthew Mosesohn (raytrac3r)]

Stable patch for 7.0mu1 subbmitted, but declined by maintenance team

[Andrey Lavrentyev (alavrentyev)]

Verification blocked by: https://bugs.launchpad.net/fuel/+bug/1515127

[Matthew Mosesohn (raytrac3r)]

This patch could be verified by running fuelmenu --save-only --iface=eth0 after deployment completes. https://bugs.launchpad.net/fuel/+bug/1515127 doesn't block this.

[Matthew Mosesohn (raytrac3r)]

https://review.openstack.org/#/c/243063/ is still pending for stable/7.0.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/243063
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=7c4dc12b9e16ef8ad1354acd53c5a6eafbafd743
Submitter: Jenkins
Branch: stable/7.0

commit 7c4dc12b9e16ef8ad1354acd53c5a6eafbafd743
Author: Matthew Mosesohn <email address hidden>
Date: Mon Nov 9 15:21:51 2015 +0300

    Disable --save-only mode during post-deployment

    Backport of https://review.openstack.org/#/c/242109/
    (full link because fuelmenu now lives in a new gitrepo)

    It is common for users to run bootstrap_admin_node to apply
    a patch to Fuel Master, which has the side effect of calling
    fuelmenu --save-only --iface=ethN. This behavior initializes
    all fields to defaults, which has negative consequences.

    Now fuelmenu --save-only --iface=ethN will result in a message
    saying that the user should run full fuelmenu in order to make
    changes.

    Change-Id: I78d3261a5e2700b7533d9873f6bec9cc4e98c362
    Closes-Bug: #1513486

[Vadim Rovachev (vrovachev)]

Verified on 7.0
Packages:
fuelmenu-7.0.0-7683.2.git7c4dc12.noarch.rpm

Checked steps in description.
w/o new packages bug reproduced
after install new packages and restart docker containers we have next message:
Not updating settings when invoked during post-deployment. Run fuelmenu manually to make changes.

[ElenaRossokhina (esolomina)]

Verified on iso#507
Following message is displayed:
Not updating settings when invoked during post-deployment.
Run fuelmenu manually to make changes.

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "507"
  build_id: "507"
  fuel-nailgun_sha: "8e954abd70ef0083109f34289de2553dcda544d4"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "ec7e212972ead554f21b52b9e165156665f659df"
  fuel-ostf_sha: "ab5fd151fc6c1aa0b35bc2023631b1f4836ecd61"
  fuel-mirror_sha: "351d568fa3b3e4dd062054b91d766aa54d379867"
  fuelmenu_sha: "234cb4cbb30fbd2df00f388c28f31606d9cae15f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "94507c5e4dad6d8cfbd8f5d41aa8389d5335990a"