Incorrect success message of remove routers with firewall in Horizon

[Bao Fangyan]

Steps to reproduce:
1) Create allow icmp rule
2) Create policy with this rule
3) Create firewall with the policy and associate router1 in Horizon
4) Click remove router,do nothing or unselect router1 then select it again.

Result:
There's a success message says:"Router(s) was successfully removed from firewall fw."

In fact,the unselected router will be remove.

[Pallavi Priya Patharlagadda (p-pallavi)]

Hi,

     I have reproduced the bug as provided in the bug description and could see the success message ""Router(s) was successfully removed from firewall fw." eventhough no routers were removed. Ideally, we should unselect the router we want to remove(by default all the routers will be selected).

     I have modified the code such that instead of the success message, the below failure message will be printed if we do nothing or unselect the router and select it again.

    "Error: Failed to remove router(s) from firewall FW: as none of the routers were unselected"

     Please provide your comments.

Thanks & Regards,
Pallavi.

[Matthias Runge (mrunge)]

you already assigned the bug to you, just go ahead and fix it.

[Yi Zhao (zhaoyi44-s)]

@Pallavi, looks good to me, just go ahead

[surbhi sarda (surbhisarda)]

according to the bug does it mean that only selected router must be removed and not the unselected router. Because in mitaka its mentioned that it will delete all the unselected routers but not the selected routers.

[Akihiro Motoki (amotoki)]

This bug still exists in Pike neutron-fwaas-dashboard.