create vip failed for unbound method get_device_name() must be called with OVSInterfaceDriver instance as first argument

[Kai Qiang Wu(Kennan)]

We found our gate failed with following information

3:42.778 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager [req-ebb92ee8-2998-4a50-baf1-8123ce76b071 admin admin] Create vip e3152b05-2c41-40ac-9729-1756664f437e failed on device driver haproxy_ns
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager Traceback (most recent call last):
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager File "/opt/stack/new/neutron-lbaas/neutron_lbaas/services/loadbalancer/agent/agent_manager.py", line 221, in create_vip
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager driver.create_vip(vip)
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager File "/opt/stack/new/neutron-lbaas/neutron_lbaas/services/loadbalancer/drivers/haproxy/namespace_driver.py", line 348, in create_vip
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager self._refresh_device(vip['pool_id'])
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager File "/opt/stack/new/neutron-lbaas/neutron_lbaas/services/loadbalancer/drivers/haproxy/namespace_driver.py", line 344, in _refresh_device
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager if not self.deploy_instance(logical_config) and self.exists(pool_id):
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager File "/usr/local/lib/python2.7/dist-packages/oslo_concurrency/lockutils.py", line 254, in inner
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager return f(*args, **kwargs)
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager File "/opt/stack/new/neutron-lbaas/neutron_lbaas/services/loadbalancer/drivers/haproxy/namespace_driver.py", line 337, in deploy_instance
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager self.create(logical_config)
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager File "/opt/stack/new/neutron-lbaas/neutron_lbaas/services/loadbalancer/drivers/haproxy/namespace_driver.py", line 92, in create
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager logical_config['vip']['address'])
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager File "/opt/stack/new/neutron-lbaas/neutron_lbaas/services/loadbalancer/drivers/haproxy/namespace_driver.py", line 248, in _plug
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager interface_name = self.vif_driver.get_device_name(Wrap(port))
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager TypeError: unbound method get_device_name() must be called with OVSInterfaceDriver instance as first argument (got Wrap instance instead)
2015-11-05 03:23:42.778 30474 ERROR neutron_lbaas.services.loadbalancer.agent.agent_manager

[Rabi Mishra (rabi)]

This bug was introduced by this fix https://review.openstack.org/#/c/241481/.

Do you've the fix ready else I can upload a fix?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/241882

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/241882
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=1191009a14ea6d839190dcb449cf42e738eb5d8f
Submitter: Jenkins
Branch: master

commit 1191009a14ea6d839190dcb449cf42e738eb5d8f
Author: Kai Qiang Wu <email address hidden>
Date: Wed Nov 4 23:14:29 2015 -0600

    Load class should be instantiate with obj

    In previous change https://review.openstack.org/#/c/241481/
    it forget make class instantiation which cause loadbalance
    function not work for vip creation.

    Change-Id: I5dcddb39aad719643def61f5f85b0ff9b2c3520d
    Closes-Bug: #1513313

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/neutron-lbaas 8.0.0.0b1 development milestone.