requirements.txt including unnecessary oslo.vmware

Bug #1513212 reported by Matthew Edmonds
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
New
Wishlist
Unassigned

Bug Description

cinder requirements.txt includes oslo.vmware. The olso_vmware module is referenced in a few of the volume/drivers/vmware files (and tests), but our policy is to then list this in test-requirements.txt and as an extra in setup.cfg, not in requirements.txt, so that setups which are not using the vmware drivers are not forced to install vmware-specific modules.

This was originally fixed under https://bugs.launchpad.net/cinder/+bug/1475739 with https://github.com/openstack/cinder/commit/e67adc385ce6997249fbf70e9402264f758fc6f4 and https://github.com/openstack/cinder/commit/478e8e970e54aaf3a034dc6347605c1b18291d0d , but then both of those patches were later reverted under https://github.com/openstack/cinder/commit/6da01c1b4102b36314b96ad73ec38a3fdec1355b. We need to get those put back, which may or may not require changing the min tox version to 1.7 from 1.6 (see https://review.openstack.org/#/c/211614/). It's not clear from the comments why that patch was abandoned in Liberty, but it should be revived for Mitaka. Or there may be another way to make the tox.ini changes that will work for 1.6, if we fail to move that up to 1.7.

Revision history for this message
Yucong Feng (yfeng) wrote :

tox version is now 1.8 for cinder. Will update with initial changes from 1475739

Changed in cinder:
assignee: nobody → Yucong Feng (yfeng)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/242257

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/242257
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in cinder:
assignee: Yucong Feng (yfeng) → Matthew Edmonds (edmondsw)
Yucong Feng (yfeng)
Changed in cinder:
assignee: Matthew Edmonds (edmondsw) → Yucong Feng (yfeng)
Changed in cinder:
assignee: Yucong Feng (yfeng) → Vipin Balachandran (vbala)
Yucong Feng (yfeng)
Changed in cinder:
assignee: Vipin Balachandran (vbala) → Yucong Feng (yfeng)
Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

It looks like the patch that was abandoned due to inactivity was pretty close to getting merged with just a few more comments to address. I think that could be reopened and this work should be completed.

If there is no longer a desire to change this though, please note that here and we can close the bug.

Changed in cinder:
importance: Undecided → Wishlist
Revision history for this message
Sean McGinnis (sean-mcginnis) wrote : Bug Assignee Expired

Unassigning due to no activity for > 6 months.

Changed in cinder:
assignee: Yucong Feng (yfeng) → nobody
Changed in cinder:
status: In Progress → New
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.