Host name of haproxy in openstack_user_config.yml causes recursion error

[Tim Hemingway]

When using the following entry in openstack_user_config.yml:

haproxy_hosts:
  haproxy:
    ip: 172.29.236.51

a recursion error will occur when running setup-hosts.yml. It appears as though this conflicts with an entry made in env.d/haproxy.yml (which also has the same name "haproxy" in container_skel). Renaming "haproxy" to "haproxy-01" will cause the issue to no longer persist. This seems to affect all versions since commit a239b29baf21dc09570b55f45d86f70581841602.

[Nolan Brubaker (nolan-brubaker)]

I can confirm this is happening on an AIO. I changed 'haproxy' in env.d/haproxy.yml's container_skel to be 'haproxy_comp' and left the host's name 'haproxy' in my openstack_user_config.yml file, and still got the recursion error.

Running `playbooks/inventory/dynamic_inventory.py --file /etc/openstack_deploy/` with a pdb trace set at line 513 (commit c6cfe818f48ec330731470c85c7aa2c568330888), I can see that the key variable alternates between 'aio1_containers' and 'haproxy_containers'.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/283149

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/283149
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=16c0193a131cc450b22b6a81b26757a0de32ac76
Submitter: Jenkins
Branch: master

commit 16c0193a131cc450b22b6a81b26757a0de32ac76
Author: Ala Raddaoui <email address hidden>
Date: Mon Feb 22 15:57:15 2016 +0000

    change host_containers group names in inventory

    In user config, when choosing host names inspired
    from containers group names, this will lead in the code
    to have host_containers to be identical to group_containers.
    This will eventually lead to unintentially having groups added
    to itselves in the inventory which will lead to unending
    recursion loop in the dynamic_inventory.py.
    Changing the way we construct the name of host_containers
    will prevent that.

    Change-Id: I5edb6091cb10588099f023f3ae961ed714aea2ce
    Closes-Bug: 1512883
    Closes-Bug: 1528953

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/openstack-ansible 14.0.0.0b2 development milestone.