Most of test_hacking.py doesn't use _assert_has_errors()

[Ryan Rossiter]

test_hacking.py has _assert_has_errors() and _assert_has_no_errors() (https://github.com/openstack/magnum/blob/master/magnum/tests/unit/test_hacking.py#L70-L77) for checking "code" (a string) against a hacking check.

Most checks in the tests are using assertEqual to make sure the hacking regex is found within the given string. Using the assertion fixtures is easier to read and understand.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/241339

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/241339
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=54414cdbb0511c71c8214d0a216078417213190f
Submitter: Jenkins
Branch: master

commit 54414cdbb0511c71c8214d0a216078417213190f
Author: Ryan Rossiter <email address hidden>
Date: Tue Nov 3 19:10:48 2015 +0000

    Use _assert_has_(no)_errors() in hacking tests

    _assert_has_errors() and _assert_has_no_errors() us much easier to read
    and understand. This change switches over the tests to use those fixture
    methods.

    Change-Id: I4aa8f973d1be34739a7fb2edcf85a956b2cf7859
    Closes-Bug: #1512802