cobbler does not properly configure dhcp_gateway

[Vladimir Khlyunev]

ISO 7.0-301 + MU1

Steps to reproduce:
1) Deploy 7.0 fuel
2) Change dhcp_gateway property in fuelmenu AFTER deployment
3) dockerctl shell cobbler cat /etc/dnsmasq.conf
OR
3) boot a slave and look at default_gw received by dhcp

Expected result:
New gateway passed to the slave/dnsmasq config was changed

Actual result:
Nothing changed, slave got old gateway.

Root cause:
cobbler::server doesn't have a dhcp_gateway parameter in its class definition

[Vladimir Khlyunev (vkhlyunev)]

I marked this bug as critical because for some reason dhcp_gateway was changed after rebuilding dockers - I will file a bug for it a little later.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/241225

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/241304

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/241225
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=ec7b42d703c6c850236d36b9f8f815a4e9db887a
Submitter: Jenkins
Branch: master

commit ec7b42d703c6c850236d36b9f8f815a4e9db887a
Author: Matthew Mosesohn <email address hidden>
Date: Tue Nov 3 17:34:22 2015 +0300

    Pass dhcp_gateway to cobbler::server class

    dhcp_gateway was somehow defaulting back to $::ipaddress
    instead of matching the values from fuel_settings.

    This corrects the scenario where a custom dhcp_gateway
    is configured, but not used.

    Change-Id: I3d2bb485f30e6c7b8e103181b98b5139cc651ff0
    Closes-Bug: #1512721

[Matthew Mosesohn (raytrac3r)]

There's a related issue in fuelmenu in --save-only mode where it resets ADMIN_NETWORK section configuration. I'll create a separate bug to handle that.

[Vasily Gorin (vgorin)]

Verifying is blocked by
https://bugs.launchpad.net/fuel/+bug/1515127

[Alexey Stupnikov (astupnikov)]

Change to Fixed Commited for 7.0-MU2, since Matthew Mosesohn told me that patch is there and waiting for a merge.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/241304
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=4d0222f905894f16948d27a32633ba9bd9ffe2c2
Submitter: Jenkins
Branch: stable/7.0

commit 4d0222f905894f16948d27a32633ba9bd9ffe2c2
Author: Matthew Mosesohn <email address hidden>
Date: Tue Nov 3 17:34:22 2015 +0300

    Pass dhcp_gateway to cobbler::server class

    dhcp_gateway was somehow defaulting back to $::ipaddress
    instead of matching the values from fuel_settings.

    This corrects the scenario where a custom dhcp_gateway
    is configured, but not used.

    Change-Id: I3d2bb485f30e6c7b8e103181b98b5139cc651ff0
    Closes-Bug: #1512721

[Denis Puchkin (dpuchkin)]

reproduced on 7.0 with the https://review.openstack.org/241304 patch

# dockerctl shell cobbler grep dhcp_gateway /etc/fuel/astute.yaml
  "dhcp_gateway": "10.20.0.2"
# dockerctl shell cobbler grep router /etc/dnsmasq.conf
dhcp-option=net:internal,option:router,10.20.0.2
# fuelmenu (change dhcp_gateway to 10.20.0.222)
# dockerctl shell cobbler grep router /etc/dnsmasq.conf
dhcp-option=net:internal,option:router,10.20.0.2
# dockerctl shell cobbler grep dhcp_gateway /etc/fuel/astute.yaml
  "dhcp_gateway": "10.20.0.222"

slave got 10.20.0.2 gateway

after stop-start cobbler contaner, /etc/dnsmasq.conf was re-generated and contain the correct dhcp_gateway

[Vitaly Sedelnik (vsedelnik)]

Reverting the fix for 7.0 because it doesn't fix the issue and causes https://bugs.launchpad.net/fuel/7.0.x/+bug/1529663

[Vitaly Sedelnik (vsedelnik)]

The fix is reverted - https://review.openstack.org/#/c/267658/2, the bug is retargeted to 7.0-mu-3

[Maksym Strukov (unbelll)]

Not fixed in 8.0-493

Steps:
1. Install Fuel
2. Execute `fuelmenu` and change dhcp_gw
3. Save and Quit
4. Check `dockerctl shell cobbler cat /etc/dnsmasq.d/default.conf | grep router`

Actual:
dhcp gw was not changed

5. Execute `dockerctl shell cobbler cobbler sync`
6. Check `dockerctl shell cobbler cat /etc/dnsmasq.d/default.conf | grep router`
Actual:
dhcp_gw was not changed

7. Execute `dockerctl restart cobbler
8. Check `dockerctl shell cobbler cat /etc/dnsmasq.d/default.conf | grep router`

Actual:
dhcp_gw was changed

[Matthew Mosesohn (raytrac3r)]

http://paste.openstack.org/show/wTTOQi8oXwy016WL1GAp/ on 9.0 is good. I'll try to reproduce on 8.0.

[Vladimir Khlyunev (vkhlyunev)]

@Matt: Did you used fuelmenu for changing dhcp-gateway >>>without any manual restarts<<<? The bug is about applying changed configuration without restarts, not about applying config at all? (I just not able to check 9.0)

[Matthew Mosesohn (raytrac3r)]

This is not broke in Fuel 8.0 either: http://paste.openstack.org/show/485625/

Vladimir simply didn't restart cobbler container. You cannot apply any config changes within containers without restarting them.

[Andrey Sledzinskiy (asledzinskiy)]

verified on 8.0-506

[Vitaly Sedelnik (vsedelnik)]

Won't Fix for 7.0-updates - there is good workaround for this issue - just to restart container to get the new config setting working. We will document it as known issue in 7.0 MU release notes.