Puppet script cannot handle the Debian package type properly

[Sergey Kolekonov]

Horizon package has been imported from Debian recently. It doesn't work with Fuel for multiple reasons:
- static collection is enabled by default in puppet-horizon module and in Fuel, but it doesn't work at all
- permission errors are observed in /var/log/apache2/error.log - http://paste.openstack.org/show/477843/

The issues can be reproduced on ISO #112 https://product-ci.infra.mirantis.net/job/8.0.all/112/

[Mikhail Ivanov (mivanov)]

Package was reverted with commit https://review.fuel-infra.org/#/c/13605/, so I think that we should close bug

[Thomas Goirand (thomas-goirand)]

This bug shall not be closed. The problem is in Puppet, *NOT* in the package.

1/ The patch should never have been reverted. I discussed the mater already. I voted -1. The patch was still reverted

2/ The package, in its current form, is still full of issues, which are present in the Ubuntu package. It is unacceptable to keep the Horizon package in its' current state, so I will have the patch merged again.

3/ The package is synced from Debian, and we will continue to do so. If you think there's a problem in the Debian package, let's fix it there first.

4/ There's been some efforts upstream to fix the situation. The following commits from upstream puppet, should be merged to MOS instead. Here's the commits:

https://review.openstack.org/#/c/241615/ <--- Prepare os_package_type
https://review.openstack.org/#/c/241218/ <--- Fix the problem with the Horizon package

While the first one has already been merged, we shall add a manual fact in /etc/facter/facts.d/os_package_type.txt and put in it: os_package_type = debian

If we do what's above, then the problem is fixed once and for all, instead of going back and forth with commits, revert, commits. Please let's move forward with this. Do not close this bug until the resolution is done properly. Also, please change the title as: "Puppet script cannot handle the Debian package type properly".

Thanks for your attention.

[Thomas Goirand (thomas-goirand)]

FYI, the above Puppet Horizon patch has been merged. So the only thin we need to do is populate the os_package_type = debian.

[Ivan Udovichenko (iudovichenko)]

We're going to adopt Debian package according to MOS requirements, and drop Ubuntu version once transition is done. I hope 2 days will be enough for this process.

[Ivan Udovichenko (iudovichenko)]

On review: https://review.fuel-infra.org/#/c/14825/

[Igor Yozhikov (iyozhikov)]

We switched back to Ubuntu source package until adaptation will be done, and behavior will be as expected from Ubuntu package.
User's experience should not get worse with this change.

[Ivan Udovichenko (iudovichenko)]

https://review.fuel-infra.org/#/c/16496/
https://review.fuel-infra.org/#/c/16693/

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Ivan Udovichenko <email address hidden> on branch: openstack-ci/fuel-8.0/liberty
Review: https://review.fuel-infra.org/14825
Reason: Not required anymore.