kolla

site.yml is confusing

Bug #1512582 reported by Sam Yaple
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Low
Sam Yaple
kolla mitaka-1 "mitaka-1"

Bug Description

site.yml has grown in complexity since it was initially created. It is not mostly unreadable due to very long lines.

This has caused several bugs due to missing something on the lines because of the length. Most recently with murano.

We can fix this by doing a line-per-item for the dicts and lists.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/241105

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/241105
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=9e7977d6094bfcdd4e25ebb390c62778661dd570
Submitter: Jenkins
Branch: master

commit 9e7977d6094bfcdd4e25ebb390c62778661dd570
Author: Sam Yaple <email address hidden>
Date: Tue Nov 3 05:47:47 2015 +0000

    Small refactor for site.yml

    As the bug mentions this file is complex and has caused problems in
    the past. It will likely cause problems in the future.

    Change-Id: I28db6a38406ce0dd38340319eea7ef9134682007
    Closes-Bug: #1512582

Changed in kolla:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/242383

Sam Yaple (s8m)
Changed in kolla:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/liberty)

Reviewed: https://review.openstack.org/242383
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=2936670f196edb3dfacf887263d39986ae544edf
Submitter: Jenkins
Branch: stable/liberty

commit 2936670f196edb3dfacf887263d39986ae544edf
Author: Sam Yaple <email address hidden>
Date: Tue Nov 3 05:47:47 2015 +0000

    Small refactor for site.yml

    As the bug mentions this file is complex and has caused problems in
    the past. It will likely cause problems in the future.

    Change-Id: I28db6a38406ce0dd38340319eea7ef9134682007
    Closes-Bug: #1512582
    (cherry picked from commit 9e7977d6094bfcdd4e25ebb390c62778661dd570)

tags: added: in-stable-liberty
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.