Murano incorrectly uses 415 instead of 406 when requested an incorrect Accept header

[Kirill Zaitsev]

Murano currently uses 415 where 406 is applicable.

415 means that server is unable to parse requests content_type
406 mean that server is unable to serve the response in the content_type, requested by accept header

This was brought to light by a webob1.5.1 that fixed usage of 415 exception.

This happens in best_match_content_type that determines requested response content-type based on Accept header.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/240902

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/240926

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/240902
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=fe15769b277bb2a7107de4317057537a9b322fae
Submitter: Jenkins
Branch: master

commit fe15769b277bb2a7107de4317057537a9b322fae
Author: Kirill Zaitsev <email address hidden>
Date: Mon Nov 2 18:25:53 2015 +0300

    Use detail instead of explanation for 415 errors

    As of webob 1.5.1 415 exception does not have explanation in it's
    template. 'detail' is present in both versions templates.
    Also adds CONTENT_TYPE to test-requests environment, to allow tests to
    run correctly.

    Change-Id: I52f2686ee838eef38ea9c5f48fe5f9e093e82412
    Partial-Bug: #1512390

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/240926
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=577c5508218de24094ac1d6ab2189b9cac4b086b
Submitter: Jenkins
Branch: stable/liberty

commit 577c5508218de24094ac1d6ab2189b9cac4b086b
Author: Kirill Zaitsev <email address hidden>
Date: Mon Nov 2 18:25:53 2015 +0300

    Use detail instead of explanation for 415 errors

    As of webob 1.5.1 415 exception does not have explanation in it's
    template. 'detail' is present in both versions templates.
    Also adds CONTENT_TYPE to test-requests environment, to allow tests to
    run correctly.

    Change-Id: I52f2686ee838eef38ea9c5f48fe5f9e093e82412
    Partial-Bug: #1512390

[Kirill Zaitsev (kzaitsev)]

Only a partial fix was merged, that unlocked the gate

[Kirill Zaitsev (kzaitsev)]

The gate part of this bug was fixed and the gate is no longer blocked

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/277817

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/277817
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=d663171fe33edb2b70e1603ce1810698819d8ba6
Submitter: Jenkins
Branch: master

commit d663171fe33edb2b70e1603ce1810698819d8ba6
Author: Konstantin Snihyr <email address hidden>
Date: Tue Feb 9 16:01:13 2016 +0300

    Replace HTTP 415 return code to HTTP 406 when it's correct

    Server must return HTTP 406 code when content type,
    specified in "Accept" header unexpected or unknown
    Otherwise server must return HTTP 415 code.
    For example, if content type parsed from "Content-Type"

    Change-Id: Ic85d1ad9e44ae722dca347b9f1dd643ba3490062
    Closes-Bug: #1512390

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/murano 2.0.0.0b3 development milestone.