ScaleIO driver should implement update_migrated_volume

[Xing Yang]

ScaleIO driver should implement update_migrated_volume.

Without implementing update_migrated_volume, when the migrate finishes, the original volume will be deleted but the name on the new volume will not be changed to the old id even though the Cinder database will get updated.

Create volume
ScaleIO Volume ID: b511a2bd00000009
ScaleIO Volume Name: TcBhywAxSsKkgovcBnEsyg==
Cinder Volume ID: 4dc061cb-0031-4ac2-a482-8bdc06712cca

Migrate started
New ScaleIO Volume ID: b511a2be00000000
New ScaleIO Volume Name: nExD3oXWR+K15Uyr/M0ucg==
New Cinder Volume ID: d1c2f94c-083a-4959-b806-3ead4f1b6b24

Migrate finished
ScaleIO Volume ID: b511a2be00000000 (okay. other volume deleted)
ScaleIO Volume Name: nExD3oX0031WR+K15Uyr/M0ucg== (bad!)
Cinder Volume ID: 4dc061cb-0031-4ac2-a482-8bdc06712cca (original ID)

The problem is that the Volume Name is a base64() encoding of the Cinder Volume ID so any OpenStack calls after the migrate fail since the lookup fails.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/240937

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/240937
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=64437898cdf58d4d028975155bda3d21a014bfe1
Submitter: Jenkins
Branch: master

commit 64437898cdf58d4d028975155bda3d21a014bfe1
Author: Xing Yang <email address hidden>
Date: Tue Oct 6 15:36:49 2015 -0400

    ScaleIO driver: update_migrated_volume

    This patch implements the update_migrated_volume function.
    Without this change, when the migrate finishes, the original
    volume will be deleted but the name on the new volume will not
    be changed to the old id even though the Cinder database will
    be updated. The volume name is a base64() encoding of the Cinder
    volume id so any calls after the migrate fail since the lookup
    fails.

    Also changed 'SCALEIO' to connector.SCALEIO now that os-brick 0.4.0
    is released.

    Closes-Bug: #1512387
    Change-Id: I70fe4bd651b0ac87b9208efb5918a4cdaf6f06b4

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/249870

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/249870
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=607c3bc0fd36336d2cdf608f4b9c485a2549b9b1
Submitter: Jenkins
Branch: stable/liberty

commit 607c3bc0fd36336d2cdf608f4b9c485a2549b9b1
Author: Xing Yang <email address hidden>
Date: Tue Oct 6 15:36:49 2015 -0400

    ScaleIO driver: update_migrated_volume

    This patch implements the update_migrated_volume function.
    Without this change, when the migrate finishes, the original
    volume will be deleted but the name on the new volume will not
    be changed to the old id even though the Cinder database will
    be updated. The volume name is a base64() encoding of the Cinder
    volume id so any calls after the migrate fail since the lookup
    fails.

    Also changed 'SCALEIO' to connector.SCALEIO now that os-brick 0.4.0
    is released.

    Closes-Bug: #1512387
    Change-Id: I70fe4bd651b0ac87b9208efb5918a4cdaf6f06b4
    (cherry picked from commit 64437898cdf58d4d028975155bda3d21a014bfe1)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/cinder 8.0.0.0b1 development milestone.

[Thierry Carrez (ttx)]

This issue was fixed in the cinder 7.0.1 release (liberty).