Wrong OVS flows created for new networks

[Eugene Nikanorov]

This is the reflection of the upstream bug: https://bugs.launchpad.net/neutron/+bug/1507776

[Eugene Nikanorov (enikanorov)]

For 8.0 this should be fixed automatically with stable/liberty sync

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: YAMAMOTO Takashi <email address hidden>
Review: https://review.fuel-infra.org/13533

[Elena Ezhova (eezhova)]

The fix for this bug is in stable/liberty: https://review.openstack.org/#/c/238986/, so this will be fixed with the stable/liberty sync: https://review.fuel-infra.org/#/c/13661/

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Elena Ezhova <email address hidden> on branch: openstack-ci/fuel-8.0/liberty
Review: https://review.fuel-infra.org/13534
Reason: See the previous comment.

[Fuel Devops McRobotson (fuel-devops-robot)]

Change restored by Ann Kamyshnikova <email address hidden> on branch: openstack-ci/fuel-8.0/liberty
Review: https://review.fuel-infra.org/13534
Reason: We need this change not closed to push new version of CR https://review.fuel-infra.org/13661

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Eugene Nikanorov <email address hidden> on branch: openstack-ci/fuel-7.0/2015.1.0
Review: https://review.fuel-infra.org/13533
Reason: got into stable/liberty

[Fuel Devops McRobotson (fuel-devops-robot)]

Change restored by Eugene Nikanorov <email address hidden> on branch: openstack-ci/fuel-7.0/2015.1.0
Review: https://review.fuel-infra.org/13533
Reason: we need that for 7.0.

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Eugene Nikanorov <email address hidden> on branch: openstack-ci/fuel-7.0/2015.1.0
Review: https://review.fuel-infra.org/13533

[Kristina Berezovskaia (kkuznetsova)]

Verify on

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "361"
  build_id: "361"
  fuel-nailgun_sha: "53c72a9600158bea873eec2af1322a716e079ea0"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "7463551bc74841d1049869aaee777634fb0e5149"
  fuel-nailgun-agent_sha: "92ebd5ade6fab60897761bfa084aefc320bff246"
  astute_sha: "c7ca63a49216744e0bfdfff5cb527556aad2e2a5"
  fuel-library_sha: "ba8063d34ff6419bddf2a82b1de1f37108d96082"
  fuel-ostf_sha: "889ddb0f1a4fa5f839fd4ea0c0017a3c181aa0c1"
  fuel-mirror_sha: "8adb10618bb72bb36bb018386d329b494b036573"
  fuelmenu_sha: "824f6d3ebdc10daf2f7195c82a8ca66da5abee99"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "9f0ba4577915ce1e77f5dc9c639a5ef66ca45896"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "07d5f1c3e1b352cb713852a3a96022ddb8fe2676"
(neutron+vxlan, 3 controllers, 2 compute)

Can't reproduce on health env. Check code for verification

[Fuel Devops McRobotson (fuel-devops-robot)]

Change restored by Max Yatsenko <email address hidden> on branch: openstack-ci/fuel-7.0/2015.1.0
Review: https://review.fuel-infra.org/13533

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Max Yatsenko <email address hidden> on branch: openstack-ci/fuel-7.0/2015.1.0
Review: https://review.fuel-infra.org/13533

[Max Yatsenko (myatsenko)]

To solve the issue for MOS7.0 - there is a patch prepared:
https://review.fuel-infra.org/#/c/36212

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/36212
Submitter: Denis V. Meltsaykin <email address hidden>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: de3f5bb993549511b1397baddaba2b80de26b57a
Author: Max Yatsenko <email address hidden>
Date: Mon Aug 21 08:36:41 2017

Fix OVS flows creation for new networks

To solve this bug two patches were used:

* Fix _restore_local_vlan_map race [1]
  Local vlan mappings provisioned by _restore_local_vlan_map
  might not be cleaned up properly if the corresponding ports are
  removed before we enter the main loop.

  This commit fixes the problem by making _restore_local_vlan_map
  just record local vlan IDs and leave the rest of provisioning logic
  to the main loop.

* Fix usage of netaddr '.broadcast' [2]
  netaddr 0.7.16 changed the behavior of ipnetworks with /31 and /32
  prefixes to make their 'broadcast' attribute return none. this patch
  replaces the use of the attribute with a -1 index lookup to get the
  last address instead.

  For stable kilo we also fix neutron/db/db_base_plugin_v2.py which had
  the checks in neutron/ipam/utils.py for Liberty.

[1] https://review.openstack.org/#/c/238986/
[2] https://review.openstack.org/#/c/218852/

Closes-Bug: #1512238
Closes-Bug: #1507776

Change-Id: I5ec8fe74307a1dcb1ff7e9cc8c2a8a9acdbd1841