Post one_tribe cleanup

[GunChleoc]

I am collecting a to-do list here for changes that we should do after one tribe has been merged. We might eventually split this up into several bugs. I will keep editing this entry

1. (Fix Committed) Expose something like ScopedTimer to the Lua interface, so we can add this to loading messages in Lua for both the world and the tribes.

2. (Fix Committed) Shift NumberGlob algorithm in Animations from C++ to Lua.

SirVer: But I just grepped the source code and realized that we never use the regular expression ability of list_directory anywhere except tests. How about changing it to do the work of NumGlob? I mean renaming it to path.list_files(pattern) (or something better). All "?" in pattern is replaced through numbers and we return a lua table with the filenames. We then guarantee that those files exist and we can already in the Lua dictionaries check that we have indeed pictures, i.e. that the config is sane. Right now, we only do it at load time

3. (Fix Committed) Since the website won't be able to parse the init.lua files, we need better help for wares in the Encyclopedia

4. (Fix Committed) All index data types used in DescriptionMaintainer (WareIndex, BuildingIndex, TerrainIndex, ResourceIndex, int) should all be of the same type (call it "DescriptionIndex").

5. (Fix Committed) We should think about refactoring the directory structure in Logic. Something along the lines of:

src/logic/map_objects: Contains the superclasses for world and tribes (MapObject, Immovable, Bob etc.)
src/logic/map_objects/tribes: Classes used in tribes only (Worker, Building etc.)
src/logic/map_objects/world: Classes used in the world only (Critter etc.)

6. (Being handled in https://bugs.launchpad.net/widelands/+bug/1512093) Add rst documentation to the Lua functions. It would be great to also have a reference for the init.lua files, e.g. how to define a new production site. We need to discuss where to put this, so the documentation will be close to the code - I think MapObjectDescr and its subclasses would be best, and Animation for the animations format.

7. (Fix Committed) Check if militarysites need to be productionsites, or if the inheritance can be shifted directly to Building. e.g. "outputs" is weird.

8. (Fix Committed) Turn static functions in Tribes into stand-alone functions.

[GunChleoc (gunchleoc)]

Fixed in build20-rc1