Neutron router interface fails on delete controller

[Matthew Mosesohn]

Steps to reproduce:
Deploy 2 controllers and 2 ceph OSD nodes (neutron vlan)
Delete primary controller

Expected results:
Successfully removed 1 controller

Actual results:
Second controller deployment failed at: Bad router request: Router already has a port on subnet 43c2687d-e75d-40ca-83de-8123fde581d4". Retrying for 9 sec.

Logs
https://drive.google.com/file/d/0B0UMyn5tu8EUY0FxQkY1eExqYTQ/view?usp=sharing

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  openstack_version: "2015.1.0-8.0"
  api: "1.0"
  build_number: "91"
  build_id: "91"
  fuel-nailgun_sha: "a1afcf0d0de61197c4a14aa014583583daa05836"
  python-fuelclient_sha: "2a1b048cc439986e222ece43a290b5cc68e92a77"
  fuel-agent_sha: "d2103bee6e216396eb8e308ec5448328c9ee4261"
  fuel-nailgun-agent_sha: "00b4b11553c250f22c0079fb74c8b782dcb7b740"
  astute_sha: "cfd5d6b916a17ad2f73e6c567a0365845155b0e3"
  fuel-library_sha: "679c1a3f15e6c32309f2c4996aea4672b28daa1a"
  fuel-ostf_sha: "1ab201cb8c3bba04522bf56ce72e863a03ff09b3"
  fuel-createmirror_sha: "6e1b82b2059a20f1fa9a4d794b976edaad156b85"
  fuelmenu_sha: "e68335c88feca803c97d75ae5a6e7de1e3f330dc"
  shotgun_sha: "bbbfccff9eb90895b13fae3fac398e65efe646f4"
  fuelmain_sha: "058e07386350bfa0a8365818cf75893949e0d863"

[Sergey Vasilenko (xenolog)]

This issue fixed in the last patchset of https://review.openstack.org/#/c/238156/
In the fuel-library cherry-picked previous.

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: master
Change author: Sergey Vasilenko <email address hidden>
Review: https://review.fuel-infra.org/13528

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: mos-8.0
Change author: Sergey Vasilenko <email address hidden>
Review: https://review.fuel-infra.org/13530

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Sergey Vasilenko <email address hidden> on branch: master
Review: https://review.fuel-infra.org/13528
Reason: wrong branch

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/13530
Submitter: Ivan Berezovskiy <email address hidden>
Branch: mos-8.0

Commit: 3463af7bee58499fdc2b8b0135df4159576ce259
Author: Sergey Vasilenko <email address hidden>
Date: Fri Oct 30 17:04:38 2015

Use json output instead plain-text

Openstack CLI utilities can returns warning messages while
run to stderr. It's a normal behavior for Openstack CLI.
But Puppet mixing stderr and stdout for commands.

For preventing parsing warning messages,
I propose got response from Neutron CLI as JSON if it required
and parse it by ruby JSON parser.

It is backport an Iba1105bc119272715fa211ac129a366fe50cbf47
from upstream puppet-neutron

Change-Id: Ibb1105bc119272715fa211ac129a366fe50cbf47
Related-bug: #1508511
Closes-bug: #1511755

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/240594

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/240594
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=9fb81504f73066f9e6835467461b4b4c2b748f90
Submitter: Jenkins
Branch: master

commit 9fb81504f73066f9e6835467461b4b4c2b748f90
Author: Sergey Vasilenko <email address hidden>
Date: Fri Oct 30 21:04:04 2015 +0300

    Backport last version of Iba1105bc119272715fa211ac129a366fe50cbf47

    from upstream.

    Change-Id: Icdc214ce794e8d608ce51eab77f7fa5c4a1a4526
    Closes-bug: #1511755
    Closes-bug: #1512021
    Related-bug: #1508511

[Dmitry Belyaninov (dbelyaninov)]

Verified on ISO #178.
Environment created by dos.py script.
Environment with 2 controllers and 2 ceph OSD nodes were deployed. After that primary controller was removed and env was deployed again successfully.

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  openstack_version: "2015.1.0-8.0"
  api: "1.0"
  build_number: "172"
  build_id: "172"
  fuel-nailgun_sha: "f8ba3f9cd449363f1c08621307e7504c304c29ae"
  python-fuelclient_sha: "e685d68c1c0d0fa0491a250f07d9c3a8d0f9608c"
  fuel-agent_sha: "61f741f4d89a3f1095dd8b494f82695fb69153d6"
  fuel-nailgun-agent_sha: "3e9d17211d65c80bf97c8d83979979f6c7feb687"
  astute_sha: "959b06c5ef8143125efd1727d350c050a922eb12"
  fuel-library_sha: "31aa9fb129a8b8739f8ca6ea186caa3c9f46820f"
  fuel-ostf_sha: "9690a2de829d3b063ed1e64b0b10dde39f711dc0"
  fuel-createmirror_sha: "22a7aacd95bbdca69f9e0f08b70facabdec8fb28"
  fuelmenu_sha: "06bbcebed6c8d0b0f9279e2997d2f958c800e98c"
  shotgun_sha: "c377d163519f6d10b69a654019d6086ba5f14edc"
  network-checker_sha: "a57e1d69acb5e765eb22cab0251c589cd76f51da"
  fuel-upgrade_sha: "1e894e26d4e1423a9b0d66abd6a79505f4175ff6"
  fuelmain_sha: "266f9b374934c64629a84b5146632cc0de70ac91"