Make a tool to check scripts for bashisms

Bug #1511721 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-resource-agents
Fix Committed
Medium
Bogdan Dobrelya

Bug Description

OCF scripts should be checked against bashisms.
The checking tool should also support a strict POSIX:2001 checks as well.
This tool may be also used for CI gates

Changed in openstack-resource-agents:
assignee: nobody → Bogdan Dobrelya (bogdando)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-resource-agents (master)

Fix proposed to branch: master
Review: https://review.openstack.org/240527

Changed in openstack-resource-agents:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-resource-agents (master)

Reviewed: https://review.openstack.org/240527
Committed: https://git.openstack.org/cgit/openstack/openstack-resource-agents/commit/?id=41f9d594ccaa3062e642d68fb06cf625a8de5d3c
Submitter: Jenkins
Branch: master

commit 41f9d594ccaa3062e642d68fb06cf625a8de5d3c
Author: Bogdan Dobrelya <email address hidden>
Date: Fri Oct 30 13:40:42 2015 +0100

    Add a script to run checkbashisms on codebase

    Requires the devscripts
    https://github.com/Debian/devscripts
    and git installed

    Closes-bug: #1511721

    Change-Id: I0da88d1dfcf82f57806d1753995719d785d8080a
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in openstack-resource-agents:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-resource-agents (master)

Fix proposed to branch: master
Review: https://review.openstack.org/275108

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-resource-agents (master)

Reviewed: https://review.openstack.org/275108
Committed: https://git.openstack.org/cgit/openstack/openstack-resource-agents/commit/?id=b1266c77ddf3a33c3521054db588c432bac40745
Submitter: Jenkins
Branch: master

commit b1266c77ddf3a33c3521054db588c432bac40745
Author: Norbert Illes <email address hidden>
Date: Mon Feb 1 16:30:05 2016 +0100

    Remove Keystone dependency from neutron-server RA

    When we check the availability of Neutron API service, now we simply
    check the response code of "List API version" call instead of getting a
    token from Keystone, then checking a Neutron API endpoint using that
    token. This way we don't need a token anymore so the checking process
    will not depend on the availability on Keystone.

    Partial-Bug: #1511721
    Change-Id: I5fee8d47bd8e9af9f415b9f74c4f9325ac99df2f
    Signed-off-by: Norbert Illes <email address hidden>

Changed in openstack-resource-agents:
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.