[systest] Test 'deploy_neutron_vlan_ha' fails with error: AttributeError: 'NoneType' object has no attribute 'name'

[Artem Panchenko]

System test 'deploy_neutron_vlan_ha' fails:

======================================================================
ERROR: Deploy cluster in HA mode with Neutron VLAN
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/7.0.custom_system_test/fuelweb_test/helpers/decorators.py", line 80, in wrapper
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/7.0.custom_system_test/fuelweb_test/tests/test_neutron.py", line 216, in deploy_neutron_vlan_ha
    logger.debug("devops node name is {0}".format(devops_node.name))
AttributeError: 'NoneType' object has no attribute 'name'

That happens because the condition with MAC addresses comparison always returns 'False' here:

https://github.com/openstack/fuel-qa/blob/master/fuelweb_test/models/fuel_web_client.py#L870-L871

So 'find_devops_node_by_nailgun_fqdn' returns 'None' instead of 'Node' object from fuel-devops. We need to improve MACs comparison in tests, so it doesn't rely on case and record format.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/239978

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/239989

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/239978
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=9356a1fa0cbc1bcf1be935d8eeb3a0707e605251
Submitter: Jenkins
Branch: master

commit 9356a1fa0cbc1bcf1be935d8eeb3a0707e605251
Author: Artem Panchenko <email address hidden>
Date: Wed Oct 28 18:06:24 2015 +0200

    Improve MAC comparison in system tests

    Change-Id: I78745dfbca1e850121bbfb8733f9cd355bf2c0c1
    Closes-bug: #1511003
    Related-bug: #1508986

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/239989
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=d456cbbbdf9f27fb336977cff2089ae795e3d549
Submitter: Jenkins
Branch: stable/7.0

commit d456cbbbdf9f27fb336977cff2089ae795e3d549
Author: Artem Panchenko <email address hidden>
Date: Wed Oct 28 18:06:24 2015 +0200

    Improve MAC comparison in system tests

    Change-Id: I78745dfbca1e850121bbfb8733f9cd355bf2c0c1
    Closes-bug: #1511003
    Related-bug: #1508986

[Artem Panchenko (apanchenko-8)]

There is another issue caused by patch regression:

Traceback (most recent call last):
  File "/usr/lib/python2.7/unittest/case.py", line 331, in run
    testMethod()
  File "/usr/lib/python2.7/unittest/case.py", line 1043, in runTest
    self._testFunc()
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 296, in testng_method_mistake_capture_func
    compatability.capture_type_error(s_func)
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/compatability/exceptions_2_6.py", line 27, in capture_type_error
    func()
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/proboscis/case.py", line 350, in func
    func(test_case.state.get_state())
  File "/home/jenkins/workspace/8.0.custom_system_test/fuelweb_test/helpers/decorators.py", line 80, in wrapper
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/8.0.custom_system_test/fuelweb_test/tests/test_neutron_tun.py", line 82, in deploy_neutron_tun
    self.fuel_web.deploy_cluster_wait(cluster_id)
  File "/home/jenkins/workspace/8.0.custom_system_test/fuelweb_test/helpers/decorators.py", line 463, in wrapper
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/8.0.custom_system_test/fuelweb_test/helpers/decorators.py", line 448, in wrapper
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/8.0.custom_system_test/fuelweb_test/helpers/decorators.py", line 499, in wrapper
    return func(*args, **kwargs)
  File "/home/jenkins/workspace/8.0.custom_system_test/fuelweb_test/helpers/decorators.py", line 506, in wrapper
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/8.0.custom_system_test/fuelweb_test/helpers/decorators.py", line 390, in wrapper
    return func(*args, **kwargs)
  File "/home/jenkins/workspace/8.0.custom_system_test/fuelweb_test/models/fuel_web_client.py", line 706, in deploy_cluster_wait
    node = self.get_devops_node_by_nailgun_node(n)
  File "/home/jenkins/workspace/8.0.custom_system_test/fuelweb_test/__init__.py", line 58, in wrapped
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/8.0.custom_system_test/fuelweb_test/models/fuel_web_client.py", line 906, in get_devops_node_by_nailgun_node
    return self.get_devops_node_by_mac(nailgun_node['mac'])
  File "/home/jenkins/workspace/8.0.custom_system_test/fuelweb_test/__init__.py", line 58, in wrapped
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/8.0.custom_system_test/fuelweb_test/models/fuel_web_client.py", line 883, in get_devops_node_by_mac
    if EUI(iface.mac_address.lower) == EUI(mac_address):
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/netaddr/eui/__init__.py", line 387, in __init__
    self.value = addr
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/netaddr/eui/__init__.py", line 423, in _set_value
    self._value = module.str_to_int(value)
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/netaddr/strategy/eui48.py", line 178, in str_to_int
    raise TypeError('%r is not str() or unicode()!' % addr)
TypeError: <buil...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/240198

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/240199

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/240198
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=9a1427b16fe8f957e3a37ba5993493c2fd4c520f
Submitter: Jenkins
Branch: master

commit 9a1427b16fe8f957e3a37ba5993493c2fd4c520f
Author: Artem Panchenko <email address hidden>
Date: Thu Oct 29 13:27:34 2015 +0200

    Fix MAC address comparison error

    Change-Id: Iaeb85505b84d37afa6de2472bd1c04126f1cf7e5
    Partial-bug: #1511003

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/240199
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=65500c26ad381df93569403c4fdeea5c1501d489
Submitter: Jenkins
Branch: stable/7.0

commit 65500c26ad381df93569403c4fdeea5c1501d489
Author: Artem Panchenko <email address hidden>
Date: Thu Oct 29 13:27:34 2015 +0200

    Fix MAC address comparison error

    Change-Id: Iaeb85505b84d37afa6de2472bd1c04126f1cf7e5
    Partial-bug: #1511003