Fuel for OpenStack

Fuel 8.0 DB migration test failed

Bug #1510999 reported by Alexander Kislitsky on 2015-10-28

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Fuel for OpenStack	Fix Released	High	Alexander Kislitsky	Fuel for OpenStack 8.0

Bug Description

Python2.7, requirements installed from nailgun/test-requirements.txt

On running migration test I have error:

$ nosetests nailgun/test/unit/test_migration_fuel_8_0.py
INFO [alembic.migration] Context impl PostgresqlImpl.
INFO [alembic.migration] Will assume transactional DDL.
INFO [alembic.migration] Running upgrade None -> 1a1504d469f8, fuel_5_0
INFO [alembic.migration] Running upgrade 1a1504d469f8 -> 52924111f7d8, fuel_5_1
INFO [alembic.migration] Running upgrade 52924111f7d8 -> 1b1d4016375d, fuel_6_0
INFO [alembic.migration] Running upgrade 1b1d4016375d -> 37608259013, Fuel 6.1 migration
INFO [alembic.migration] Running upgrade 37608259013 -> 1e50a4903910, Fuel 7.0
INFO [alembic.migration] Context impl PostgresqlImpl.
INFO [alembic.migration] Will assume transactional DDL.
INFO [alembic.migration] Running upgrade 1e50a4903910 -> 43b2cb64dae6, Fuel 8.0
......E.....
======================================================================
ERROR: test_unique_name_fields_insert_unique (nailgun.test.unit.test_migration_fuel_8_0.TestNodeGroupsMigration)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/sand/PycharmProjects/fuel-web/nailgun/nailgun/test/unit/test_migration_fuel_8_0.py", line 264, in test_unique_name_fields_insert_unique
    'name': uuid.uuid4()})
  File "/home/sand/PycharmProjects/fuel-web/nailgun/nailgun/test/unit/test_migration_fuel_8_0.py", line 80, in insert_table_row
    [row_data]
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/orm/scoping.py", line 150, in do
    return getattr(self.registry(), name)(*args, **kwargs)
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/orm/session.py", line 991, in execute
    bind, close_with_result=True).execute(clause, params or {})
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 729, in execute
    return meth(self, multiparams, params)
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/sql/elements.py", line 322, in _execute_on_connection
    return connection._execute_clauseelement(self, multiparams, params)
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 826, in _execute_clauseelement
    compiled_sql, distilled_params
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 958, in _execute_context
    context)
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1159, in _handle_dbapi_exception
    exc_info
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/util/compat.py", line 199, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb)
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 951, in _execute_context
    context)
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/engine/default.py", line 436, in do_execute
    cursor.execute(statement, parameters)
ProgrammingError: (ProgrammingError) can't adapt type 'UUID' 'INSERT INTO nodegroups (cluster_id, name) VALUES (%(cluster_id)s, %(name)s) RETURNING nodegroups.id' {'cluster_id': 1, 'name': UUID('4fc652cf-45bd-4c3c-bdc4-f2e0ea676094')}

---------------------------------------------------------------------- File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 826, in _execute_clauseelement
    compiled_sql, distilled_params
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 958, in _execute_context
    context)
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1159, in _handle_dbapi_exception
    exc_info
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/util/compat.py", line 199, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb)
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 951, in _execute_context
    context)
  File "/home/sand/.virtualenvs/fuel/local/lib/python2.7/site-packages/sqlalchemy/engine/default.py", line 436, in do_execute
    cursor.execute(statement, parameters)
ProgrammingError: (ProgrammingError) can't adapt type 'UUID' 'INSERT INTO nodegroups (cluster_id, name) VALUES (%(cluster_id)s, %(name)s) RETURNING nodegroups.id' {'cluster_id': 1, 'name': UUID('4fc652cf-45bd-4c3c-bdc4-f2e0ea676094')}

----------------------------------------------------------------------

Fix is simple - to wrap uuid.uuid4() to six.text_type

Tags:

Dmitry Pyzhov (dpyzhov) on 2015-10-28

tags:

added: tech-debt

Alexander Kislitsky (akislitsky) on 2015-10-29

Changed in fuel:
assignee:	Fuel Python Team (fuel-python) → Alexander Kislitsky (akislitsky)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-10-29: Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/240156

Changed in fuel:
status:	Triaged → In Progress

OpenStack Infra (hudson-openstack) on 2015-10-29

Changed in fuel:
assignee:	Alexander Kislitsky (akislitsky) → Igor Kalnitsky (ikalnitsky)

OpenStack Infra (hudson-openstack) on 2015-10-30

Changed in fuel:
assignee:	Igor Kalnitsky (ikalnitsky) → Alexander Kislitsky (akislitsky)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-10-30: Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/240156
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=a53a1679f4b613c715d351c14362e11c85df852d
Submitter: Jenkins
Branch: master

commit a53a1679f4b613c715d351c14362e11c85df852d
Author: Alexander Kislitsky <email address hidden>
Date: Thu Oct 29 11:01:45 2015 +0300

Migration test for 8.0 fixed

Result of uuid.uuid4 casted to text before insertiation to DB.
str() replaced with six.text_type()

Change-Id: I8cbe3ca274c33244589abc08c71722ca9db5cedf
Closes-Bug: #1510999

Changed in fuel:
status:	In Progress → Fix Committed

Dmitry Pyzhov (dpyzhov) on 2015-11-05

tags:

added: area-python

ElenaRossokhina (esolomina) on 2015-11-30

tags:

added: on-verification

Revision history for this message

ElenaRossokhina (esolomina) wrote on 2015-12-01:

Download full text (5.2 KiB)

Verified on Fuel 229 build, environment created by dos.py (version 2.9.12)

Logs:
(fuel-devops-venv-es)esolomina@srv023-scc:~/fuel-web/nailgun$ python -V
Python 2.7.6
(fuel-devops-venv-es)esolomina@srv023-scc:~/fuel-web/nailgun$ nosetests nailgun/test/unit/test_migration_fuel_8_0.py
INFO [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO [alembic.runtime.migration] Will assume transactional DDL.
INFO [alembic.runtime.migration] Running upgrade -> 1a1504d469f8, fuel_5_0
INFO [alembic.runtime.migration] Running upgrade 1a1504d469f8 -> 52924111f7d8, fuel_5_1
INFO [alembic.runtime.migration] Running upgrade 52924111f7d8 -> 1b1d4016375d, fuel_6_0
INFO [alembic.runtime.migration] Running upgrade 1b1d4016375d -> 37608259013, Fuel 6.1 migration
INFO [alembic.runtime.migration] Running upgrade 37608259013 -> 1e50a4903910, Fuel 7.0
INFO [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO [alembic.runtime.migration] Will assume transactional DDL.
INFO [alembic.runtime.migration] Running upgrade 1e50a4903910 -> 43b2cb64dae6, Fuel 8.0
..................
----------------------------------------------------------------------
Ran 18 tests in 5.010s

Verified on Fuel 229 build, environment created by dos.py (version 2.9.12)

Logs:
(fuel-devops-venv-es)esolomina@srv023-scc:~/fuel-web/nailgun$ python -V
Python 2.7.6
(fuel-devops-venv-es)esolomina@srv023-scc:~/fuel-web/nailgun$ nosetests nailgun/test/unit/test_migration_fuel_8_0.py
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade  -> 1a1504d469f8, fuel_5_0
INFO  [alembic.runtime.migration] Running upgrade 1a1504d469f8 -> 52924111f7d8, fuel_5_1
INFO  [alembic.runtime.migration] Running upgrade 52924111f7d8 -> 1b1d4016375d, fuel_6_0
INFO  [alembic.runtime.migration] Running upgrade 1b1d4016375d -> 37608259013, Fuel 6.1 migration
INFO  [alembic.runtime.migration] Running upgrade 37608259013 -> 1e50a4903910, Fuel 7.0
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade 1e50a4903910 -> 43b2cb64dae6, Fuel 8.0
..................
----------------------------------------------------------------------
Ran 18 tests in 5.010s

OK
(fuel-devops-venv-es)esolomina@srv023-scc:~/fuel-web/nailgun$ nosetests nailgun/test/unit/test_migration_fuel_8_0.py -v
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade  -> 1a1504d469f8, fuel_5_0
INFO  [alembic.runtime.migration] Running upgrade 1a1504d469f8 -> 52924111f7d8, fuel_5_1
INFO  [alembic.runtime.migration] Running upgrade 52924111f7d8 -> 1b1d4016375d, fuel_6_0
INFO  [alembic.runtime.migration] Running upgrade 1b1d4016375d -> 37608259013, Fuel 6.1 migration
INFO  [alembic.runtime.migration] Running upgrade 37608259013 -> 1e50a4903910, Fuel 7.0
INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
INFO  [alembic.runtime.migration] Running upgrade 1e50a4903910 -> 43b2cb64dae6, Fuel 8.0
test_baremetal_fields_saving (nailgun.test.unit.test_migration_fuel_8_0.TestBaremetalFields) ... ok
test_moving_plugin_attributes (nailgun.test.unit.test_migration_fuel_8_0.TestClusterPluginsMigration) ... ok
test_plugin_a_is_enabled (nailgun.test.unit.test_migration_fuel_8_0.TestClusterPluginsMigration) ... ok
test_plugin_b_is_disabled (nailgun.test.unit.test_migration_fuel_8_0.TestClusterPluginsMigration) ... ok
test_bootstrap_field_exists_and_filled (nailgun.test.unit.test_migration_fuel_8_0.TestMasterSettingsMigration) ... ok
test_internal_name_and_floating_names_are_added (nailgun.test.unit.test_migration_fuel_8_0.TestNeutronConfigInternalFloatingNames) ... ok
test_internal_name_and_floating_names_defaults (nailgun.test.unit.test_migration_fuel_8_0.TestNeutronConfigInternalFloatingNames) ... ok
test_neutron_config_is_updated_in_releases (nailgun.test.unit.test_migration_fuel_8_0.TestNeutronConfigInternalFloatingNames) ... ok
test_node_error_type_enum (nailgun.test.unit.test_migration_fuel_8_0.TestNodeErrorTypeMigration) ... ok
test_name_cluster_unique_constraint_migration (nailgun.test.unit.test_migration_fuel_8_0.TestNodeGroupsMigration) ... ok
test_unique_name_fields_insert_duplicated (nailgun.test.unit.test_migration_fuel_8_0.TestNodeGroupsMigration) ... ok
test_unique_name_fields_insert_unique (nailgun.test.unit.test_migration_fuel_8_0.TestNodeGroupsMigration) ... ok
test_new_component_metadata_field_exists_and_empty (nailgun.test.unit.test_migration_fuel_8_0.TestPluginMigration) ... ok
test_new_component_metadata_field_exists_and_empty (nailgun.test.unit.test_migration_fuel_8_0.TestReleaseMigrations) ... ok
test_release_is_deployable_deleted (nailgun.test.unit.test_migration_fuel_8_0.TestReleaseMigrations) ... ok
test_releases_are_manageonly (nailgun.test.unit.test_migration_fuel_8_0.TestReleaseMigrations) ... ok
test_task_name_enum (nailgun.test.unit.test_migration_fuel_8_0.TestTaskNameMigration) ... ok
test_pending_status_saving (nailgun.test.unit.test_migration_fuel_8_0.TestTaskStatus) ... ok

----------------------------------------------------------------------
Ran 18 tests in 4.945s

OK
(fuel-devops-venv-es)esolomina@srv023-scc:~/fuel-web/

FUEL info
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  openstack_version: "2015.1.0-8.0"
  api: "1.0"
  build_number: "229"
  build_id: "229"
  fuel-nailgun_sha: "28025f978a6c5d23e7441ad3ec8c2b9f123d9d15"
  python-fuelclient_sha: "b77559b309a62650658424a43051cfeaba518748"
  fuel-agent_sha: "1672c18c8193e1b93d5687d8b720cf4f1ea07048"
  fuel-nailgun-agent_sha: "a33a58d378c117c0f509b0e7badc6f0910364154"
  astute_sha: "b60624ee2c5f1d6d805619b6c27965a973508da1"
  fuel-library_sha: "b9f8c28f0e8f7d725ed4211df418fc54a1abd728"
  fuel-ostf_sha: "fc6648be21f26fac4f66ef18ba36f521960d554b"
  fuel-createmirror_sha: "1f3b4ae09d01591e59449448955dd4254b38ce23"
  fuelmenu_sha: "4064b7723773ab89cdfcbf6cf4682215a7757104"
  shotgun_sha: "25a0cc461a9fa4f7684f04cef0ff4ad9aa99a64d"
  network-checker_sha: "0b1b94a9685c6471d6911dff7ecac10b7bd2625f"
  fuel-upgrade_sha: "1e894e26d4e1423a9b0d66abd6a79505f4175ff6"
  fuelmain_sha: "2eca6adc33f02e02cd812e1d4be7c70e05fd07db"

tags:	removed: on-verification
Changed in fuel:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.