Volume stays in 'in-use' state after detach

[Sergii Rizvan]

Corresponding upstream bug: https://bugs.launchpad.net/tempest/+bug/1302774

api: '1.0'
astute_sha: ef8aa0fd0e3ce20709612906f1f0551b5682a6ce
auth_required: true
build_id: 2014-12-03_01-07-36
build_number: '48'
feature_groups:
- mirantis
fuellib_sha: a3043477337b4a0a8fd166dc83d6cd5d504f5da8
fuelmain_sha: 7626c5aeedcde77ad22fc081c25768944697d404
nailgun_sha: 500e36d08a45dbb389bf2bd97673d9bff48ee84d
ostf_sha: 64cb59c681658a7a55cc2c09d079072a41beb346
production: docker
release: 5.1.1
release_versions:
  2014.1.3-5.1.1:
    VERSION:
      api: '1.0'
      astute_sha: ef8aa0fd0e3ce20709612906f1f0551b5682a6ce
      build_id: 2014-12-03_01-07-36
      build_number: '48'
      feature_groups:
      - mirantis
      fuellib_sha: a3043477337b4a0a8fd166dc83d6cd5d504f5da8
      fuelmain_sha: 7626c5aeedcde77ad22fc081c25768944697d404
      nailgun_sha: 500e36d08a45dbb389bf2bd97673d9bff48ee84d
      ostf_sha: 64cb59c681658a7a55cc2c09d079072a41beb346
      production: docker
      release: 5.1.1

If we try to detach volume from instance immediately after attach, we end up with a volume in an undeletable state (it remains marked in-use, but it not attached to instance).

Commands to reproduce: http://pastebin.com/V4giZ9Av

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-5.1.1-updates/2014.1.1
Change author: Nikola Dipanov <email address hidden>
Review: https://review.fuel-infra.org/13263

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/13263
Submitter: Vitaly Sedelnik <email address hidden>
Branch: openstack-ci/fuel-5.1.1-updates/2014.1.1

Commit: 53fa43d33d559ce598fb5f2b932747181f3bf926
Author: Nikola Dipanov <email address hidden>
Date: Wed Nov 11 10:49:33 2015

Make begin_detaching fail if volume not "in-use"

Like it's counterpart from Nova's volume-attach functionality standpoint
- reserve_volume, begin_detaching should fail if the volume is not in
  the correct state to be detached. This will prevent nova from
attempting to check and then detach, which is inherently racy.

Change-Id: Ie87eb0c9aea068affc94032ab2e53a91888d272a
Closes-Bug: #1510957

[Vadim Rovachev (vrovachev)]

Verified on 5.1.1