[ipv6] proxy should not raise exception if storage rel not ready

Bug #1510940 reported by Edward Hope-Morley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
swift-proxy (Juju Charms Collection)
Fix Released
Critical
Edward Hope-Morley

Bug Description

Currently if the storage relation fires but does not have the required information we raise an exception. Instead we should just ignore the event and wait for the next one.

2015-10-28 13:11:39 INFO juju-log swift-storage:60: Leader established, updating ring builders
2015-10-28 13:11:39 INFO swift-storage-relation-changed Traceback (most recent call last):
2015-10-28 13:11:39 INFO swift-storage-relation-changed File "/var/lib/juju/agents/unit-swift-proxy-0/charm/hooks/swift-storage-relation-changed", line 537, in <module>
2015-10-28 13:11:39 INFO swift-storage-relation-changed main()
2015-10-28 13:11:39 INFO swift-storage-relation-changed File "/var/lib/juju/agents/unit-swift-proxy-0/charm/hooks/swift-storage-relation-changed", line 530, in main
2015-10-28 13:11:39 INFO swift-storage-relation-changed hooks.execute(sys.argv)
2015-10-28 13:11:39 INFO swift-storage-relation-changed File "/var/lib/juju/agents/unit-swift-proxy-0/charm/hooks/charmhelpers/core/hookenv.py", line 704, in execute
2015-10-28 13:11:39 INFO swift-storage-relation-changed self._hooks[hook_name]()
2015-10-28 13:11:39 INFO swift-storage-relation-changed File "/var/lib/juju/agents/unit-swift-proxy-0/charm/hooks/charmhelpers/core/host.py", line 393, in wrapped_f
2015-10-28 13:11:39 INFO swift-storage-relation-changed f(*args, **kwargs)
2015-10-28 13:11:39 INFO swift-storage-relation-changed File "/var/lib/juju/agents/unit-swift-proxy-0/charm/hooks/swift-storage-relation-changed", line 212, in storage_changed
2015-10-28 13:11:39 INFO swift-storage-relation-changed raise SwiftProxyCharmException(errmsg)
2015-10-28 13:11:39 INFO swift-storage-relation-changed lib.swift_utils.SwiftProxyCharmException: Did not get IPv6 address from storage relation (got=10.232.16.6)
2015-10-28 13:11:39 ERROR juju.worker.uniter.operation runhook.go:103 hook "swift-storage-relation-changed" failed: exit status 1

Related branches

Revision history for this message
Edward Hope-Morley (hopem) wrote :

A juju-resolved -r does fix this but we should improve the code to avoid it happening in the first place.

summary: - proxy should not exception if storage rel not ready
+ [ipv6] proxy should not raise exception if storage rel not ready
Changed in swift-proxy (Juju Charms Collection):
assignee: nobody → Edward Hope-Morley (hopem)
milestone: none → 16.01
importance: Undecided → Critical
status: New → In Progress
tags: added: backport-potential openstack sts
Changed in swift-proxy (Juju Charms Collection):
status: In Progress → Fix Committed
James Page (james-page)
Changed in swift-proxy (Juju Charms Collection):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.