Wrong execution state with conditional transitions

[Nikolay Makhotkin]

The following workflow should fail if we do not pass variable 'var' but it succeed.

Something wrong with final workflow execution state analysis.

---
version: '2.0'

wfwf:
  input:
    - var: null

  tasks:
    task1:
      action: std.fail
      on-success:
        - task2
      on-error:
        - task3: <% $.var != null %>

[Syed Ahsan Shamim Zaidi (ahsanmohsin04)]

Hi,

Can you kindly provide more detail so that i can look it up.

Thanks

[Nikolay Makhotkin (nmakhotkin)]

Hi,

It is kind of very specific bug in mistral engine, I can't provide more details on that.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/242431
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=6662bec3140de91cf2329060e4e3867f2c2859ce
Submitter: Jenkins
Branch: master

commit 6662bec3140de91cf2329060e4e3867f2c2859ce
Author: Nikolay Mahotkin <email address hidden>
Date: Fri Nov 6 13:29:54 2015 +0300

    Fixing workflow execution state calculation

     * Fixed workflow execution state calculation
     when it didn't take to account conditional
     transitions (Error was considered handled even
     if transition doesn't trigger a task)

    Closes-Bug: #1510936

    Change-Id: Ia694b6dba9ab2ce9bff2da1fe05f5988864619d9

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/246839

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/246839
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=99a804d21769bd756b29b80c973d2d919f5aff1d
Submitter: Jenkins
Branch: stable/liberty

commit 99a804d21769bd756b29b80c973d2d919f5aff1d
Author: Nikolay Mahotkin <email address hidden>
Date: Fri Nov 6 13:29:54 2015 +0300

    Fixing workflow execution state calculation

     * Fixed workflow execution state calculation
     when it didn't take to account conditional
     transitions (Error was considered handled even
     if transition doesn't trigger a task)

    Closes-Bug: #1510936

    Change-Id: Ia694b6dba9ab2ce9bff2da1fe05f5988864619d9
    (cherry picked from commit 6662bec3140de91cf2329060e4e3867f2c2859ce)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/mistral 2.0.0.0b1 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/mistral 1.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/mistral 1.0.1 release.