update_modules.sh does not work on OSX due to lack of timeout command

Bug #1510665 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Alex Schultz

Bug Description

With change https://review.openstack.org/#/c/235333/, a timeout command was used to try and prevent librarian-puppet from hanging CI. The problem is that if no timeout command is available the script no longer functions and returns 1. Specifically on OSX this breaks the update_modules.sh and the noop test scripts.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/239740

Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Alex Schultz (alex-schultz)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/239740
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=99c054c732286a4b62193c391313c0bd012fdbf1
Submitter: Jenkins
Branch: master

commit 99c054c732286a4b62193c391313c0bd012fdbf1
Author: Alex Schultz <email address hidden>
Date: Tue Oct 27 14:03:08 2015 -0500

    Fix update_modules.sh to handle missing timeout cmd

    This change fixes the update_modules.sh scrip so that if the 'timeout'
    command is not available it will no longer error. Previously if the
    system did not have a 'timeout' command, the update_modules.sh script
    would fail silently and return 1.

    Change-Id: I7b469b65a30bfe2af8acf62bebabf10c9af1e374
    Closes-Bug: #1510665

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Pyzhov (dpyzhov)
tags: added: area-library
tags: added: tech-debt
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-library (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/297611

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.