Oxide

Stop using the form factor for detecting memory constrained devices

Bug #1510603 reported by Chris Coulson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Oxide
Fix Released
Medium
Chris Coulson
Oxide branch-1.17

Bug Description

We currently use the form factor for detecting memory constrained devices, but this is wrong. A better metric would be the amount of physical memory and swap space available.

Chris Coulson (chrisccoulson)
Changed in oxide:
importance: Undecided → Low
status: New → Triaged
Chris Coulson (chrisccoulson)
Changed in oxide:
importance: Low → Medium
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

This is currently used in:

- ContentClient::ShouldOptimizeForMemoryUsage (an Oxide modification to Chromium for limiting decoded image sizes and the discardable shared memory size).
- ContentMainDelegate::PreSandboxStartup for limiting the size of the Skia font cache.

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

It's also used in RendererFrameEvictor, but I'd like to refactor how this code works.

Chris Coulson (chrisccoulson)
Changed in oxide:
status: Triaged → In Progress
assignee: nobody → Chris Coulson (chrisccoulson)
milestone: none → branch-1.15
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

RendererFrameEvictor has been deleted in http://bazaar.launchpad.net/~oxide-developers/oxide/oxide.trunk/revision/1432

Chris Coulson (chrisccoulson)
Changed in oxide:
milestone: branch-1.15 → branch-1.16
Chris Coulson (chrisccoulson)
Changed in oxide:
milestone: branch-1.16 → branch-1.17
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

https://git.launchpad.net/~oxide-developers/oxide/+git/chromium/commit/?id=8abf81019b7f405d0d0002c470ebf7fa7e557fc9 and https://git.launchpad.net/oxide/commit/?id=39cc163cf7696e669e7e0942a32b9c1cd8c1473d (not on trunk yet because it required a Chromium change)

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

And https://git.launchpad.net/oxide/commit/?id=6ed5433f7ecfc194a2384350d45f040d1d146eee

Changed in oxide:
status: In Progress → Fix Committed
Chris Coulson (chrisccoulson)
Changed in oxide:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.