OpenStack-Ansible

scripts-library.sh can no longer be sourced outside of openstack-ansible checkout

Bug #1510443 reported by Matt Thompson on 2015-10-27

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
OpenStack-Ansible	Fix Released	High	Matt Thompson	OpenStack-Ansible mitaka-1
Liberty	Fix Released	High	Jesse Pretorius	OpenStack-Ansible 12.0.1
Trunk	Fix Released	High	Matt Thompson	OpenStack-Ansible mitaka-1

Bug Description

Previously, we could source openstack-ansible/scripts/scripts-library.sh from anywhere, but this is now failing due to the following line:

eval "$(python $(dirname ${0})/os-detection.py)"

Matt Thompson (mattt416) on 2015-10-27

Changed in openstack-ansible:
assignee:	nobody → Matt Thompson (mattt416)
importance:	Undecided → High

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-10-27: Fix proposed to openstack-ansible (master)

Fix proposed to branch: master
Review: https://review.openstack.org/239631

Changed in openstack-ansible:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-11-02: Fix merged to openstack-ansible (master)

Reviewed: https://review.openstack.org/239631
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=b5a6381457bce88413b4c6865f929ef086297d18
Submitter: Jenkins
Branch: master

commit b5a6381457bce88413b4c6865f929ef086297d18
Author: Matt Thompson <email address hidden>
Date: Tue Oct 27 09:52:25 2015 +0000

Allow scripts-library.sh to be sourced anywhere

    Currently, we cannot source scripts-library.sh from anywhere outside of
    the top-level of the openstack-ansible checkout. This behaviour
    changed with commit d9b9a427aa03f866458bdffc220c596c7b4b5bb2.

    This commit itself updates scripts-library.sh to use $BASH_SOURCE to
    find the location of os-detection.py, allowing scripts-library.sh to
    be sourced from any external project without having to cd into the
    openstack-ansible checkout and back out again.

Change-Id: Ia5cec5a0f1af4f8d4998465923077c87ffaf24ef
Closes-Bug: #1510443

Changed in openstack-ansible:
status:	In Progress → Fix Committed

Jesse Pretorius (jesse-pretorius) on 2015-11-02

Changed in openstack-ansible:
milestone:	none → mitaka-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-11-02: Fix proposed to openstack-ansible (liberty)

Fix proposed to branch: liberty
Review: https://review.openstack.org/240923

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-11-09: Fix merged to openstack-ansible (liberty)

Reviewed: https://review.openstack.org/240923
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=48eabfc6971c04dd2282db96dee4f839311a4bd0
Submitter: Jenkins
Branch: liberty

commit 48eabfc6971c04dd2282db96dee4f839311a4bd0
Author: Matt Thompson <email address hidden>
Date: Tue Oct 27 09:52:25 2015 +0000

Allow scripts-library.sh to be sourced anywhere

    Change-Id: Ia5cec5a0f1af4f8d4998465923077c87ffaf24ef
    Closes-Bug: #1510443
    (cherry picked from commit b5a6381457bce88413b4c6865f929ef086297d18)