New Charm: IBM Platform RTM

[Prabakaran]

Hello Team,

Here is a updated charm for IBM Platform RTM V9.1.4 for review.

To test the IBM Platform RTM , we need Maria DB 5.5 charm. As per the design changes, the Platform RTM charm is subordinate charm for Mariadb 5.5

Deployable ibm-platform-rtm layer charm can be found in the below repository.
Repo : https://code.launchpad.net/~ibmcharmers/charms/trusty/ibm-platform-rtm/trunk

And, its source code can be found in the below repository
Repo : https://code.launchpad.net/~ibmcharmers/charms/trusty/layer-ibm-platform-rtm/trunk

The charm has been pushed into charm store as well
branch : cs:~ibmcharmers/trusty/ibm-platform-rtm-8

Thanks

[Marco Ceppi (marcoceppi)]

This bug is filed against the wrong path. You have it filed against IBM Charms, but it needs to be filed against the Charms distribution. I have corrected this.

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/1434/

[Review Queue (review-queue)]

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/1422/

[Kevin W Monroe (kwmonroe)]

Hi Prabakaran / Rajith. Thanks for the submission and request to make IBM Platform RTM a recommended application in the charm store. Unfortunately, we cannot recommend this charm in its current state. Outstanding issues:

- config.yaml: values are never used. Since this charm uses terms and resources, these config options are no longer needed. If RTM has no other configuration available, remove the config.yaml.

- layer.yaml: again since this charm uses terms and resources, there is no need to use the ibm base layer here (the primary purpose of the ibm base layer was to offer license acceptance and curl helpers for charms that could not leverage terms and resources). I recommend removing 'layer:ibm-base' from layer.yaml.

- README.md: the process for deploying mariadb-5.5 has changed recently. I committed an update to the readme with current instructions and a few formatting changes:

http://bazaar.launchpad.net/~ibmcharmers/charms/trusty/layer-ibm-platform-rtm/trunk/revision/2#README.md

- tests/01-deploy.py: lots of simple lint errors here need to be fixed (incorrect whitespace, unused imports, etc). Run 'flake8 ./tests/*.py to see the errors. More importantly, mariadb is never added to the deployment. You'll need to include something like this to deploy mariadb-5.5 since it is required by this charm:

self.d.add('mariadb')
self.d.configure('mariadb', {'series': '5.5'})

- reactive/ibm-platform-rtm.sh
  - This code is very difficult to follow because of inconsistent formatting. Please be consistent with function open/closing braces (ie: '{' on the function line or by itself) as well as indentation throughout the code (ie: indent the body of a function consistently).

  - I could not determine a valid reason for disabling the firewall. Instead, you could call 'open-port 80' and instruct the user run 'juju expose ibm-platform-rtm' in the readme. Security guidelines in the charm author policy say the following (note: disabling the firewall is not a best practice):

https://jujucharms.com/docs/stable/authors-charm-policy
...
Must provide a means to protect users from known security vulnerabilities in a way consistent with best practices
...

  - The charm does not need to apt install mariadb-client-core because the mariadb charm will handle that for you.

  - The 'check_mariadb_inst()' function must not 'exit 0'. This will cause the running hook to always succeed which means this charm would never handle the case where mariadb was unavailable.

  - In 'ibm_prtm_INSTALL()', the charm should not copy resources to a new location, and it should not have the resource tarball name hard coded. The charm could instead do something like this:

cd /var/lib/juju/agents/*rtm*/resources
res_name=`resource-get 'ibm_prtm_installer'
tar -xvf $res_name

  - The charm must not 'wget' files from the internet without some verification of the payload integrity. I recommend defining resources for each of the plugins that are currently fetched with wget and push those to the charm store to live alongside this charm. The charm would then use 'resource-get' for each plugin just as it does for the main installers. FYI, the relevant guideline from the charm author policy...

[rajith (rajith-pv)]

Hi Kevin,
We have made changes for above recommendations, However we have two issues:

1) With resources in Juju charm each file is uploaded in different folder under resources, while installing rtm poller file all other plugins and rtm server file need to be in same folder. Rtm installation config file is pointing to one working directory, we are unable to point to multiple directories, so I am copying files one working directory

2)For RTM installation we need to firewall to be disabled and port 80 is open. Please refer this RTM Knowledge center:
http://www.ibm.com/support/knowledgecenter/SSVMSD_9.1.4/install/install_rtm_ubuntu.html

[rajith (rajith-pv)]

Removed code for disabling firewall, got recommendation from product team to install rtm without disabling firewall.

[Kevin W Monroe (kwmonroe)]

Thanks for the updates to this charm -- this review has been migrated to the new review queue:

https://review.jujucharms.com/reviews/35

Te latest version of platform-rtm has been imported and should be reviewed shortly.