[system-tests] Replace ipaddr to netaddr in system tests

[Dmitry Tyzhnenko]

Because we have started use EUI module from netaddr package for work with mac addresses [1] we should stop using ipaddr package because modules do not have compatibilities.

[1] - https://github.com/openstack/fuel-qa/blob/bd5e806553a89b41b97eae71b703d97b66623214/fuelweb_test/models/fuel_web_client.py#L819

[Artem Panchenko (apanchenko-8)]

Dmitry,

as far as I know we switched to 'ipaddr' in fuel-qa because it's used by fuel-devops and we wanted to make them more strict (for example bug #1433656). Could you please explain why 'ipaddr' module can't be used along with 'netaddr' in fuel-qa, because for me the issue is not clear?

[Dmitry Tyzhnenko (dtyzhnenko)]

Artem,

We will get AttributeError, when try create netaddr.IPNetwork from instance of ipaddr.IPNetwork. We should more careful if we using two packages in tests

net1 = ipaddr.IPNetwork('10.109.0.0/24')
net2 = netaddr.IPNetwork('10.109.1.0/24')

net1, net2
(IPv4Network('10.109.0.0/24'), IPNetwork('10.109.1.0/24'))

net3 = ipaddr.IPNetwork(net2)
net3
IPv4Network('10.109.1.0/24')

net4 = netaddr.IPNetwork(net1)
AttributeError: 'IPv4Network' object has no attribute '_value'

[Artem Panchenko (apanchenko-8)]

Dmitry,

for me that's absolutely fine. Those objects types have the same name, but they are different, so we can't compare them and so on. Currently we use 'ipaddr' and 'netaddr' modules in different places, that's why I believe there is no issue with compatibility.