dockerctl version override does not work correctly

Bug #1510080 reported by Matthew Mosesohn
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Matthew Mosesohn

Bug Description

dockerctl -V $FUEL_RELEASE $command $args should work, but it usually leads to an error:

Steps to reproduce:
1 - dockerctl -V 8.0 start postgres

Expected results:
fuel-core-8.0-postgres is already running.

Actual results:
Invalid selection.
Usage:
  /usr/bin/dockerctl command

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  openstack_version: "2015.1.0-8.0"
  api: "1.0"
  build_number: "243"
  build_id: "2015-10-16_13-57-36"
  fuel-nailgun_sha: "445cb68b3fdeec4836d92a3c8f7cb998b951f759"
  python-fuelclient_sha: "93a2e63d2a035c3f6f8ac2f7c3ba22b89696bbef"
  fuel-agent_sha: "5d2d5e2e9ad4f8bb01e450240d85447608d84b92"
  fuel-nailgun-agent_sha: "08e0a11cf1f29b705e4b910d9b9db5e9b708b6e3"
  astute_sha: "a090546d43c770ac27ca81c6f8c78ff0ba4a93e0"
  fuel-library_sha: "eb2ba3eb154cae59ef6f4d25d5c091e89d8b3044"
  fuel-ostf_sha: "6aeb20eeb40706879fe9f8d19ba21340d2c6dbb2"
  fuel-createmirror_sha: "fe81731b76071dc0a4ffdf039080732243f5a871"
  fuelmain_sha: "d873a118ef1efc6b7722feaa9a31c2ef48a3b53e"

Tags: area-library
Changed in fuel:
milestone: none → 8.0
assignee: nobody → Matthew Mosesohn (raytrac3r)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/239445

Dmitry Pyzhov (dpyzhov)
tags: added: area-library
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/239445
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=247d5d81e371b8da97916cc6d69ad58db7ee8b2c
Submitter: Jenkins
Branch: master

commit 247d5d81e371b8da97916cc6d69ad58db7ee8b2c
Author: Matthew Mosesohn <email address hidden>
Date: Mon Oct 26 17:17:25 2015 +0300

    Fix version override of Fuel release in dockerctl

    Corrects options handling did not handle override
    of version so that one can correctly use the
    following commands:
    dockerctl -V 8.0 start postgres
    dockerctl --version 7.0 destroy nginx

    The wrong variable was in the template leaving the
    version defaulted to "", and then reverting to 8.0
    as hardocded by the RPM. Switched to @release var
    name.

    Fixed varname for dockerctl config in hardcoded conf
    distributed in the RPM so it does not get replaced.

    Change-Id: Ia864b0a9843f927aa85945e5ab0b2da4bec3a440
    Related-Commit: I28032852517ec8f7e959ad48a04621ec3e33fea1
    Related-Bug: #1501368
    Closes-Bug: #1510080

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Anastasia Palkina (apalkina) wrote :

Verified on ISO #91

"fuel-createmirror_sha": "6e1b82b2059a20f1fa9a4d794b976edaad156b85", "shotgun_sha": "bbbfccff9eb90895b13fae3fac398e65efe646f4", "api": "1.0", "fuelmain_sha": "058e07386350bfa0a8365818cf75893949e0d863", "astute_sha": "cfd5d6b916a17ad2f73e6c567a0365845155b0e3", "fuel-ostf_sha": "1ab201cb8c3bba04522bf56ce72e863a03ff09b3", "openstack_version": "2015.1.0-8.0", "build_id": "91", "fuelmenu_sha": "e68335c88feca803c97d75ae5a6e7de1e3f330dc", "build_number": "91", "auth_required": true, "fuel-library_sha": "679c1a3f15e6c32309f2c4996aea4672b28daa1a", "fuel-nailgun-agent_sha": "00b4b11553c250f22c0079fb74c8b782dcb7b740", "fuel-nailgun_sha": "a1afcf0d0de61197c4a14aa014583583daa05836", "fuel-agent_sha": "d2103bee6e216396eb8e308ec5448328c9ee4261", "production": "docker", "python-fuelclient_sha": "2a1b048cc439986e222ece43a290b5cc68e92a77", "feature_groups": ["mirantis"], "release": "8.0", "release_versions": {"2015.1.0-8.0": {"VERSION": {"fuel-createmirror_sha": "6e1b82b2059a20f1fa9a4d794b976edaad156b85", "shotgun_sha": "bbbfccff9eb90895b13fae3fac398e65efe646f4", "api": "1.0", "fuelmain_sha": "058e07386350bfa0a8365818cf75893949e0d863", "astute_sha": "cfd5d6b916a17ad2f73e6c567a0365845155b0e3", "fuel-ostf_sha": "1ab201cb8c3bba04522bf56ce72e863a03ff09b3", "openstack_version": "2015.1.0-8.0", "build_id": "91", "fuelmenu_sha": "e68335c88feca803c97d75ae5a6e7de1e3f330dc", "build_number": "91", "fuel-library_sha": "679c1a3f15e6c32309f2c4996aea4672b28daa1a", "fuel-nailgun-agent_sha": "00b4b11553c250f22c0079fb74c8b782dcb7b740", "fuel-nailgun_sha": "a1afcf0d0de61197c4a14aa014583583daa05836", "fuel-agent_sha": "d2103bee6e216396eb8e308ec5448328c9ee4261", "production": "docker", "python-fuelclient_sha": "2a1b048cc439986e222ece43a290b5cc68e92a77", "feature_groups": ["mirantis"], "release": "8.0"}}}

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.