fuelmenu adds dhcp_nowait when calling l23network

Bug #1510059 reported by Dmitry Teselkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Matthew Mosesohn

Bug Description

dhcp_nowait option is disabled in l23network.
However, fuelmenu still adds it when calling puppet.

https://github.com/openstack/fuel-web/search?utf8=%E2%9C%93&q=dhcp_nowait&type=Code

Tags: area-python
affects: mos → fuel
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-menu (master)

Fix proposed to branch: master
Review: https://review.openstack.org/239469

Changed in fuel:
assignee: nobody → Matthew Mosesohn (raytrac3r)
status: New → In Progress
Maciej Relewicz (rlu)
Changed in fuel:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-menu (master)

Reviewed: https://review.openstack.org/239469
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=15cdf516175d40176b4bdc81e595f86697ae4430
Submitter: Jenkins
Branch: master

commit 15cdf516175d40176b4bdc81e595f86697ae4430
Author: Matthew Mosesohn <email address hidden>
Date: Mon Oct 26 18:41:10 2015 +0300

    Disable dhcp_nowait and fail on DHCP if none detected

    dhcp_nowait was removed a long time ago from L23network
    puppet module, so it cannot be used as an option for enabling
    DHCP when there are no available DHCP servers. Since we are
    checking for the presence of DHCP servers, we should fail to
    apply configuration instead of waiting for Puppet to fail.

    Change-Id: Ia8275d32b13a22d56922cd4a6fd6528bb7c77692
    Closes-Bug: #1510059

Changed in fuel:
status: In Progress → Fix Committed
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: none → 8.0
Dmitry Pyzhov (dpyzhov)
tags: added: area-library
tags: added: area-python
removed: area-library
Revision history for this message
Dmitry Belyaninov (dbelyaninov) wrote :

Verified on ISO #519

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.