Magnum

Use assertTrue/False instead of assertEqual(T/F)

Bug #1510001 reported by Bertrand Lallau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Undecided
Bertrand Lallau
Magnum
Fix Released
Undecided
Bertrand Lallau
Magnum mitaka-1
senlin
Fix Released
Low
lvdongbing

Bug Description

We should use assert(False|True) not assertEqual(False|True, ***).

OpenStack Infra (hudson-openstack)
Changed in magnum:
assignee: nobody → Bertrand Lallau (bertrand-lallau)
status: New → In Progress
Revision history for this message
venkatamahesh (venkatamaheshkotha) wrote :

https://review.openstack.org/#/c/239349/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to designate (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/239423

OpenStack Infra (hudson-openstack)
Changed in designate:
assignee: nobody → Bertrand Lallau (bertrand-lallau)
status: New → In Progress
lvdongbing (dbcocle)
Changed in senlin:
assignee: nobody → lvdongbing (dbcocle)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to senlin (master)

Fix proposed to branch: master
Review: https://review.openstack.org/239609

Changed in senlin:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/239349
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=2eea193d775ba2c70b13469e9b798929d1642457
Submitter: Jenkins
Branch: master

commit 2eea193d775ba2c70b13469e9b798929d1642457
Author: Bertrand Lallau <email address hidden>
Date: Mon Oct 26 07:55:56 2015 +0100

    Use assertTrue/False instead of assertEqual(T/F)

    The usage of assertEqual(True/False, ***) should be changed to a more
    meaningful format of assertTrue/False(***).

    Closes-Bug: #1510001
    Change-Id: Ia16af467d5f5bfca029002d9d261540947b0be92

Changed in magnum:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to senlin (master)

Reviewed: https://review.openstack.org/239609
Committed: https://git.openstack.org/cgit/openstack/senlin/commit/?id=813a83b030227e3753c489c7eab799da9cfb09f4
Submitter: Jenkins
Branch: master

commit 813a83b030227e3753c489c7eab799da9cfb09f4
Author: lvdongbing <email address hidden>
Date: Tue Oct 27 03:14:47 2015 -0400

    Use assertTrue/False instead of assertEqual(T/F)

    The usage of assertEqual(True/False, ***) should be changed to a more
    meaningful format of assertTrue/False(***).

    Closes-Bug: #1510001
    Change-Id: I5203e9a8170d7af4e0cfac789f77a35d513d985a

Changed in senlin:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/239423
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=69217969efd4c5c49dde7aa0e4f20e51a8b10ba9
Submitter: Jenkins
Branch: master

commit 69217969efd4c5c49dde7aa0e4f20e51a8b10ba9
Author: Bertrand Lallau <email address hidden>
Date: Mon Oct 26 13:34:06 2015 +0100

    Use assertTrue/False instead of assertEqual(T/F)

    Usage of assertEqual(True/False, ***) should be changed to a more
    meaningful format of assertTrue/False(***).

    Change-Id: I8623f5534f00ea1690f74a297488957a8d35f074
    Closes-Bug: #1510001

Changed in designate:
status: In Progress → Fix Committed
Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
status: Fix Committed → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/heat 6.0.0.0b1

This issue was fixed in the openstack/heat 6.0.0.0b1 development milestone.

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/designate 2.0.0.0b1

This issue was fixed in the openstack/designate 2.0.0.0b1 development milestone.

Doug Hellmann (doug-hellmann)
Changed in designate:
status: Fix Committed → Fix Released
Qiming Teng (tengqim)
Changed in senlin:
status: Fix Committed → Fix Released
importance: Undecided → Low
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/senlin 1.0.0.0b2

This issue was fixed in the openstack/senlin 1.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.