Missing contrib.amulet in charm-helpers-hooks

[james beedy]

charmhelpers.contrib.openstack.amulet.utils imports AmuletUtils from charmhelpers.contrib.amulet.utils which does not exist.

OpenStackAmuletUtils can't inherit its base class because it doesn't exist.

Charm-helpers-hooks missing contrib.amulet.

Nonexistent import in charm here -> http://bazaar.launchpad.net/~charm-helpers/charm-helpers/devel/view/head:/charmhelpers/contrib/openstack/amulet/utils.py#L34

*** This is fixed by adding an import to contrib.amulet in charm-helpers-hooks, although I'm not sure if having the inter-charm-helper-package dependency is appropriate....

[james beedy (jamesbeedy)]

Fixed here: https://code.launchpad.net/~jamesbeedy/charms/trusty/heat/fix-non-existent-import/+merge/275584

[Felipe Reyes (freyes)]

@jamesbeedy, it's true that the hooks/charmhelpers directory doesn't include a copy of contrib.amulet, but amulet related code is intended to be used only from the tests/ directory, which it does contain contrib.amulet[0][1].

Could you provide an example of where this import issue is affecting you?.

[0] https://github.com/openstack/charm-heat/blob/master/charm-helpers-tests.yaml#L4
[1] https://github.com/openstack/charm-heat/tree/master/tests/charmhelpers/contrib/amulet

[Felipe Reyes (freyes)]

I'm marking this bug as incomplete until more information is provided.

[Launchpad Janitor (janitor)]

[Expired for heat (Juju Charms Collection) because there has been no activity for 60 days.]