I can create a VolumeGroup (vg0) without having created a partition on the boot disk (and obviously, fails to deploy)
Bug #1509536 reported by
Andres Rodriguez
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Critical
|
Blake Rouse | ||
Bug Description
When configuring the boot disk with LVM, I need to create a partition on the disk before I can create a Volume Group. However, MAAS allowed me to 'Create Volume Group' without having created a partition. This causes the node to fail to deploy.
MAAS should either:
1. Automatically create the sda-part1 when Create Volume Group on the boot disk.
2. or it should prevent from 'Create Volume Group' (and show a message saying that the user needs to create a partition).
To reproduce:
1. Select 'sda'
2. 'Create Volume Group'
3. Select vg0 & 'Add Logical Volume'
4. Select vg0-lv0 & 'Format'
5. Deploy
Install log: http://
Related branches
lp:~blake-rouse/maas/fix-1509536-part1
- Mike Pontillo (community): Approve
-
Diff: 1260 lines (+428/-119)21 files modifiedsrc/maasserver/api/tests/test_blockdevice.py (+7/-7)
src/maasserver/api/tests/test_node.py (+3/-2)
src/maasserver/api/tests/test_nodes.py (+2/-1)
src/maasserver/forms.py (+81/-35)
src/maasserver/models/blockdevice.py (+22/-0)
src/maasserver/models/filesystem.py (+12/-0)
src/maasserver/models/tests/test_blockdevice.py (+22/-1)
src/maasserver/models/tests/test_filesystem.py (+19/-0)
src/maasserver/models/tests/test_node.py (+7/-7)
src/maasserver/models/tests/test_partitiontable.py (+5/-5)
src/maasserver/models/tests/test_physicalblockdevice.py (+4/-4)
src/maasserver/testing/factory.py (+9/-4)
src/maasserver/tests/test_forms_bcache.py (+61/-14)
src/maasserver/tests/test_forms_cacheset.py (+29/-3)
src/maasserver/tests/test_forms_raid.py (+74/-1)
src/maasserver/tests/test_forms_volume_group.py (+30/-0)
src/maasserver/tests/test_node_constraint_filter_forms.py (+25/-25)
src/maasserver/tests/test_preseed_storage.py (+8/-4)
src/maasserver/tests/test_storage_layouts.py (+4/-3)
src/maasserver/websockets/tests/test_listener.py (+2/-1)
src/metadataserver/models/tests/test_commissioningscript.py (+2/-2)
lp:~blake-rouse/maas/fix-1509536-part3
- Mike Pontillo (community): Approve
- Andres Rodriguez (community): Needs Information
-
Diff: 103 lines (+76/-3)2 files modifiedsrc/maasserver/preseed_storage.py (+9/-3)
src/maasserver/tests/test_preseed_storage.py (+67/-0)
lp:~blake-rouse/maas/fix-1509536-part2
- Mike Pontillo (community): Approve
-
Diff: 105 lines (+77/-0)2 files modifiedsrc/maasserver/models/node.py (+35/-0)
src/maasserver/models/tests/test_node.py (+42/-0)
Revision history for this message
| Andres Rodriguez (andreserl) wrote | #1 |
| summary: |
- I can create vg0 without having created a partition + Creating vg0 without having created a partition |
| summary: |
- Creating vg0 without having created a partition + Creating vg0 without having created a partition on the boot disk fails + to deploy |
| summary: |
- Creating vg0 without having created a partition on the boot disk fails - to deploy + I can create a VolumeGroup (vg0) without having created a partition on + the boot disk |
| description: | updated |
| Changed in maas: | |
| assignee: | nobody → Andres Rodriguez (andreserl) |
| assignee: | Andres Rodriguez (andreserl) → nobody |
| milestone: | none → 1.9.0 |
| importance: | Undecided → Critical |
| summary: |
I can create a VolumeGroup (vg0) without having created a partition on - the boot disk + the boot disk (and obviously, fails to deploy) |
| description: | updated |
| tags: | added: ux |
| tags: | added: storage ui |
| Changed in maas: | |
| status: | New → Triaged |
| Changed in maas: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Blake Rouse (blake-rouse) |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is only when the disk chosen is the bootdisk. And it requires a partition to be created before putting vg0 on it.