[system-tests] System test failed with assertion in get_devops_node_by_nailgun_node(): TypeError: 'Node' object has no attribute '__getitem__'

[Dennis Dmitriev]

System test 'ha_neutron_destroy_controllers' failed while searching for non-primary controller in the HA cluster with 3 controllers:

https://github.com/openstack/fuel-qa/blob/master/fuelweb_test/tests/tests_strength/test_failover_base.py#L154-L155

----------------
Traceback (most recent call last):
...
  File "/home/jenkins/workspace/8.0.system_test.ubuntu.ha_neutron_destructive/fuelweb_test/tests/tests_strength/test_failover_base.py", line 155, in ha_destroy_controllers
    controllers.pop(0))
  File "/home/jenkins/workspace/8.0.system_test.ubuntu.ha_neutron_destructive/fuelweb_test/__init__.py", line 58, in wrapped
    result = func(*args, **kwargs)
  File "/home/jenkins/workspace/8.0.system_test.ubuntu.ha_neutron_destructive/fuelweb_test/models/fuel_web_client.py", line 906, in get_devops_node_by_nailgun_node
    return self.get_devops_node_by_mac(nailgun_node['mac'])
TypeError: 'Node' object has no attribute '__getitem__'
----------------

ISO version:
 build_id 51
 openstack_version 2015.1.0-8.0
 release_versions:
    2015.1.0-8.0:
       VERSION:
          build_id 51
          openstack_version 2015.1.0-8.0
          fuel-library_sha 56f55f373aff9a115a92414a6395780e75860d03
          fuel-createmirror_sha 05d86902d57fb1dfb1b764b140148a03908ebe4b
          feature_groups:
              - mirantis
          fuel-nailgun-agent_sha abab45cf8c7344d43acd3858c02d7a648ef7fee6
          python-fuelclient_sha 398b003a840e361c09b166f1a05e6c7bd92ba416
          fuel-nailgun_sha b94e3840a75abe79dcd9060f81bfa38f8864b5d3
          fuel-agent_sha 49e2e8a08a3cf39d1b38ee155015332aa84e47fd
          api 1.0
          fuelmain_sha eb669555ca18b0fb372c53857f1c7b2f10e669dd
          astute_sha 7cea69bd021d6132cde473cdd25e5142fdddad95
          fuel-ostf_sha 618eb749d78cce075c2b14664b59a06d92f142c2
          release 8.0
          build_number 51
          production docker
 auth_required True
 fuel-library_sha 56f55f373aff9a115a92414a6395780e75860d03
 fuel-createmirror_sha 05d86902d57fb1dfb1b764b140148a03908ebe4b
 feature_groups:
     - mirantis
 fuel-nailgun-agent_sha abab45cf8c7344d43acd3858c02d7a648ef7fee6
 python-fuelclient_sha 398b003a840e361c09b166f1a05e6c7bd92ba416
 fuel-nailgun_sha b94e3840a75abe79dcd9060f81bfa38f8864b5d3
 fuel-agent_sha 49e2e8a08a3cf39d1b38ee155015332aa84e47fd
 api 1.0
 fuelmain_sha eb669555ca18b0fb372c53857f1c7b2f10e669dd
 astute_sha 7cea69bd021d6132cde473cdd25e5142fdddad95
 fuel-ostf_sha 618eb749d78cce075c2b14664b59a06d92f142c2
 release 8.0
 build_number 51
 production docker

Reproduced on CI: https://product-ci.infra.mirantis.net/job/8.0.system_test.ubuntu.ha_neutron_destructive/25/testReport/%28root%29/ha_neutron_destroy_controllers/ha_neutron_destroy_controllers/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/238896

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/238896
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=c83e2a7d0257f18bcb013103f4620f7a8c1e65c5
Submitter: Jenkins
Branch: master

commit c83e2a7d0257f18bcb013103f4620f7a8c1e65c5
Author: Dennis Dmitriev <email address hidden>
Date: Fri Oct 23 15:02:00 2015 +0300

    Fix getting first/second ctrls in the test 'ha_neutron_destructive'

    - use the list of non-primary devops nodes instead of getting
      controllers inside the loop;
    - use self.show_step() for monitor steps position in logs

    Change-Id: I9d81cf9479a862f167059580f2e6a8431835e48e
    Closes-Bug:#1509286