Spaces allowed as key-pair name

[Christoph Held]

Steps to reproduce:

1. Open launch instance dialog
2. Switch to tab Access & Security
3. Click on '+' icon under the KeyPair Section
3. Enter one space into name field
4. Paste key
5. Click import key pair

Expected result:
- Key name is trimmed and rejected

Observed result:
- Key is imported
- Empty line appears in key selection fields

Remark:
- see also: https://bugs.launchpad.net/horizon/+bug/1288583

[Floren (florenllanos)]

Hello,

Please, don't change the status from "New" to "In progress". It change automatically when you send to review the patch.

Regards.

[Rob Cresswell (robcresswell-deactivatedaccount)]

Removed assignee due to inactivity.

[Rob Cresswell (robcresswell-deactivatedaccount)]

This actually has very odd behaviour. Horizon acts as if the keypair has been created and directs you to the download keypair screen; however, the API call fails so hitting Download will error.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/303651

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/303651
Reason: Abandoning for now, hasn't been updated in 4 months. Feel free to restore and update if you get time to work on the patch. Thanks!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/350747

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/350747
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d829313834a1f3176eef2b450999c54e35ea960f
Submitter: Jenkins
Branch: master

commit d829313834a1f3176eef2b450999c54e35ea960f
Author: Rebecca Finn <email address hidden>
Date: Wed Aug 3 18:58:47 2016 +0000

    Do not allow spaces as key pair name

    This fixes a bug where spaces were treated as a valid key pair
    name.

    Change-Id: Ie0dc31111db3753b8fb9f31159da9fb43d5a74aa
    Closes-Bug: #1509217

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/horizon 10.0.0.0b3 development milestone.