Spaces allowed as key-pair name

Bug #1509217 reported by Christoph Held
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Rebecca Finn

Bug Description

Steps to reproduce:

1. Open launch instance dialog
2. Switch to tab Access & Security
3. Click on '+' icon under the KeyPair Section
3. Enter one space into name field
4. Paste key
5. Click import key pair

Expected result:
- Key name is trimmed and rejected

Observed result:
- Key is imported
- Empty line appears in key selection fields

Remark:
- see also: https://bugs.launchpad.net/horizon/+bug/1288583

Changed in horizon:
assignee: nobody → Amulya Battu (battu-amulya)
status: New → In Progress
Revision history for this message
Floren (florenllanos) wrote :

Hello,

Please, don't change the status from "New" to "In progress". It change automatically when you send to review the patch.

Regards.

Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Removed assignee due to inactivity.

Changed in horizon:
status: In Progress → Confirmed
assignee: Amulya Battu (battu-amulya) → nobody
tags: added: low-hanging-fruit nova
Changed in horizon:
milestone: none → ongoing
importance: Undecided → Low
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

This actually has very odd behaviour. Horizon acts as if the keypair has been created and directs you to the download keypair screen; however, the API call fails so hitting Download will error.

Changed in horizon:
milestone: ongoing → next
Ayush Singh (singh-ay)
Changed in horizon:
assignee: nobody → Ayush Singh (singh-ay)
Ayush Singh (singh-ay)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/303651

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/303651
Reason: Abandoning for now, hasn't been updated in 4 months. Feel free to restore and update if you get time to work on the patch. Thanks!

Changed in horizon:
assignee: Ayush Singh (singh-ay) → nobody
status: In Progress → Confirmed
Changed in horizon:
assignee: nobody → Rebecca Finn (rebeccax-finn)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/350747

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/350747
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d829313834a1f3176eef2b450999c54e35ea960f
Submitter: Jenkins
Branch: master

commit d829313834a1f3176eef2b450999c54e35ea960f
Author: Rebecca Finn <email address hidden>
Date: Wed Aug 3 18:58:47 2016 +0000

    Do not allow spaces as key pair name

    This fixes a bug where spaces were treated as a valid key pair
    name.

    Change-Id: Ie0dc31111db3753b8fb9f31159da9fb43d5a74aa
    Closes-Bug: #1509217

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
milestone: next → newton-3
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b3

This issue was fixed in the openstack/horizon 10.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.