PHP warning during 1.6/1.7/1.8 -> 15.10 upgrade

[Aaron Wells]

To replicate:

1. Clean install of Mahara 1.6.5
2. Log in to Mahara
3. Upgrade to Mahara 15.10.0 (via the web browser)

Result: The upgrade works as expected, but PHP prints this warning:

[WAR] ea (lib/errors.php:747) Failed to get a recordset: postgres8 error: [-18: ERROR: relation "institution_config" does not exist
LINE 1: DELETE FROM "institution_config" WHERE field LIKE '%/_nav/_%...
                    ^] in EXECUTE("DELETE FROM "institution_config" WHERE field LIKE '%/_nav/_%' ESCAPE '/'")
Command was: DELETE FROM "institution_config" WHERE field LIKE '%/_nav/_%' ESCAPE '/'
Call stack (most recent first):

    log_message("Failed to get a recordset: postgres8 error: [-18: ...", 8, true, true) at /home/aaronw/www/mahara-clients/htdocs/lib/errors.php:97
    log_warn("Failed to get a recordset: postgres8 error: [-18: ...") at /home/aaronw/www/mahara-clients/htdocs/lib/errors.php:747
    SQLException->__construct("Failed to get a recordset: postgres8 error: [-18: ...") at /home/aaronw/www/mahara-clients/htdocs/lib/dml.php:974
    delete_records_sql("DELETE FROM {institution_config} WHERE field LIKE ...", array(size 0)) at /home/aaronw/www/mahara-clients/htdocs/lib/web.php:3011
    clear_menu_cache() at /home/aaronw/www/mahara-clients/htdocs/admin/upgrade.json.php:70

[Aaron Wells (u-aaronw)]

This happens with version 1.6, 1.7, or 1.8, because the institution_config table wasn't added until Mahara 1.9.

[Aaron Wells (u-aaronw)]

Setting priority to low, because the warning only happens if you've got an older out-of-support Mahara version, and it doesn't actually break anything.

[Kristina Hoeppner (kris-hoeppner)]

Setting to "Won't fix" as these are now very old versions of Mahara that will most likely need other intervention during an upgrade anyway.