*_COMPLETE/FAILED status is still set too early

Bug #1508990 reported by Thomas Herve
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Thomas Herve

Bug Description

Basically, a reference to bug #1450314. We didn't really fixed that bug, only workaround it in the update case. http://logs.openstack.org/49/238349/1/check/gate-heat-dsvm-functional-orig-mysql/52f73c4/ shows that it can happen for suspend, and I've also seen it for delete. We should apply the same workaround.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/238576

Changed in heat:
status: New → In Progress
Revision history for this message
Rabi Mishra (rabi) wrote :

We did some changes recently to set the stack status(COMPLETE/FAILED) and release the lock in the same DB transaction.

I believe that fixed some of the ActionInProgress issues.

https://github.com/openstack/heat/commit/e2294da861c24d538cafe1c54d038e2b5d4ba594

There are some related bugs I'm still investigating

1. https://bugs.launchpad.net/heat/+bug/1503955
2. https://bugs.launchpad.net/heat/+bug/1503180

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/238576
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=def34d7a0525e2b7f0a611efee2d10142c2e6005
Submitter: Jenkins
Branch: master

commit def34d7a0525e2b7f0a611efee2d10142c2e6005
Author: Thomas Herve <email address hidden>
Date: Thu Oct 22 17:29:21 2015 +0200

    Expand test in-progress workaround

    When working around bug #1450314, we changed integration tests to ignore
    the lock when doing an update. Unfortunately, this issue happens for
    actions other than update like delete and suspend, so let's apply the
    same fix for those actions too.

    Change-Id: I04c5f35a1851163bc849f5c8be0f6e865ee0088e
    Closes-Bug: #1508990
    Related-Bug: #1450314

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/heat 6.0.0.0b1

This issue was fixed in the openstack/heat 6.0.0.0b1 development milestone.

Changed in heat:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.