No permanent distinguisher for default node network group

[Aleksey Kasatkin]

Versions: 6.0 - 7.0.

When new environment is created default node network group is created in there (which is connected to shared Admin network). It is named 'default'. This name is the only distinguisher of default node network group which is being used in several places in code. But the name of node network group is not read-only entity. It can be changed via API. So, this distinguisher can be lost easily, data processing in Nailgun become broken in this case.

Permanent distinguisher for default node network group should be introduced.

[Aleksey Kasatkin (alekseyk-ru)]

After a discussion it was decided (preliminary) that new foreign key 'default_node_group' in 'clusters' table can be created to be used as such permanent distinguisher.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/259904

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/261347

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/259904
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=64c0711e1595bf8fe783b250e5ba154c70652494
Submitter: Jenkins
Branch: master

commit 64c0711e1595bf8fe783b250e5ba154c70652494
Author: Artem Roma <email address hidden>
Date: Mon Dec 21 10:26:38 2015 +0200

    Add distinguisher field for default node group

    What was done:
    * new field to node group orm model class added - boolean flag 'default';
    * alembic migration for 8.0 version updated respectively;
    * code that operates on default node group changed in regard of new
      attribute;
    * checking logic of CheckBeforeDeploymentTask._validate_network_template
      refactored;
    * related tests updated.

    Change-Id: If751ea8d11fe7d7d01616e695998f3c276a12b5c
    Closes-Bug: #1508973

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/261471

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/261347
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=fe53afff95fda5693d1d15f97d8c93aa497187d0
Submitter: Jenkins
Branch: stable/8.0

commit fe53afff95fda5693d1d15f97d8c93aa497187d0
Author: Artem Roma <email address hidden>
Date: Mon Dec 21 10:26:38 2015 +0200

    Add distinguisher field for default node group

    What was done:
    * new field to node group orm model class added - boolean flag 'default';
    * alembic migration for 8.0 version updated respectively;
    * code that operates on default node group changed in regard of new
      attribute;
    * checking logic of CheckBeforeDeploymentTask._validate_network_template
      refactored;
    * related tests updated.

    Change-Id: If751ea8d11fe7d7d01616e695998f3c276a12b5c
    Closes-Bug: #1508973

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/8.0
Review: https://review.openstack.org/262192

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/261471
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=2c3dd30d68505932c57443289afb068b778ce382
Submitter: Jenkins
Branch: master

commit 2c3dd30d68505932c57443289afb068b778ce382
Author: Julia Aranovich <email address hidden>
Date: Fri Dec 25 13:06:25 2015 +0300

    Fix handling of default node network group in Fuel UI

    To check if node network group is default group,
    'is_default' attribute of node network group should be used
    instead of comparing with 'default' node networ group name

    Related-Bug: #1508973

    Change-Id: Ie59423a9751e4353c243cd22c5924b25e6937e66

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/262192
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=d413f5ad276541b2ead60cd0fe700840e4eb8f76
Submitter: Jenkins
Branch: stable/8.0

commit d413f5ad276541b2ead60cd0fe700840e4eb8f76
Author: Julia Aranovich <email address hidden>
Date: Fri Dec 25 13:06:25 2015 +0300

    Fix handling of default node network group in Fuel UI

    To check if node network group is default group,
    'is_default' attribute of node network group should be used
    instead of comparing with 'default' node networ group name

    Related-Bug: #1508973

    Change-Id: Ie59423a9751e4353c243cd22c5924b25e6937e66

[Artem Panchenko (apanchenko-8)]

verified

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "506"
  build_id: "506"
  fuel-nailgun_sha: "8e954abd70ef0083109f34289de2553dcda544d4"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "ec7e212972ead554f21b52b9e165156665f659df"
  fuel-ostf_sha: "ab5fd151fc6c1aa0b35bc2023631b1f4836ecd61"
  fuel-mirror_sha: "351d568fa3b3e4dd062054b91d766aa54d379867"
  fuelmenu_sha: "234cb4cbb30fbd2df00f388c28f31606d9cae15f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "94507c5e4dad6d8cfbd8f5d41aa8389d5335990a"