Remove l3 deprecated options

Bug #1508188 reported by Cedric Brandily
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Expired
Low
Unassigned

Bug Description

dhcp/l3 agent use_namespaces and external_network_bridge options has been deprecated in Liberty[1,2].

Now kernels property support namespaces, removing this option allow to simplify agent code and remove an option (use_namespaces == False) not functionally tested.

[1] https://bugs.launchpad.net/neutron/+bug/1435382
[2] https://review.openstack.org/#/c/219928/

Tags: l3-ipam-dhcp
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/238213

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-vpnaas (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/239568

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-fwaas (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/239570

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-fwaas (master)

Fix proposed to branch: master
Review: https://review.openstack.org/239770

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/239570
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=e50e0c5a4bd1eb15a005a1f238ded062ea115a38
Submitter: Jenkins
Branch: master

commit e50e0c5a4bd1eb15a005a1f238ded062ea115a38
Author: Cedric Brandily <email address hidden>
Date: Tue Oct 27 11:47:46 2015 +0900

    Prepare neutron "use_namespaces" option removal

    The neutron use_namespaces option is deprecated since Kilo, it's time
    remove it from neutron, neutron-*aas and devstack. This change removes
    use_namespaces option usage in unit/functional tests in order to prepare
    option removal from neutron and tests testing use_namespace=False case.
    This change continues to define use_namespaces option because it's
    required by neutron code without using neutron
    register_use_namespaces_opts_helper which will be removed from neutron.

    Related-Bug: #1508188
    Change-Id: I303038eec560a6d99421140c2822aed8b518470b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/238213
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=23b907bc6e87be153c13b1bf3e069467cdda0d27
Submitter: Jenkins
Branch: master

commit 23b907bc6e87be153c13b1bf3e069467cdda0d27
Author: Cedric Brandily <email address hidden>
Date: Wed Oct 21 20:52:40 2015 +0200

    Remove deprecated use_namespaces option

    The use_namespaces option has been defined as a workaround to kernels
    not properly supporting namespaces. This limitation is behind us, it's
    time to remove use_namespaces after its deprecation in Kilo in order to
    simplify code and remove a poorly tested case (use_namespaces=False).

    This change prepares for removal pullup_route method[1] which was only
    used when use_namespaces=False.

    [1] neutron.agent.linux.ip_lib

    DocImpact
    UpgradeImpact
    Closes-Bug: #1508188
    Related-Bug: #1435382
    Depends-On: I303038eec560a6d99421140c2822aed8b518470b
    Depends-On: I4feb2a15c7e1e4bfdbed2531b18b8e7d798ab3cc
    Change-Id: I2fbf65df1250d9f9f1656b3964ee3b6de1ef1118

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-fwaas (master)

Reviewed: https://review.openstack.org/239770
Committed: https://git.openstack.org/cgit/openstack/neutron-fwaas/commit/?id=750cd05b3492850b50602e965c729fbc37ee7030
Submitter: Jenkins
Branch: master

commit 750cd05b3492850b50602e965c729fbc37ee7030
Author: Cedric Brandily <email address hidden>
Date: Wed Oct 28 08:39:36 2015 +0900

    Remove deprecated use_namespaces option

    use_namespace option has been removed from neutron so we can cleanup
    neutron-fwaas.

    Closes-Bug: #1508188
    Depends-On: I2fbf65df1250d9f9f1656b3964ee3b6de1ef1118
    Change-Id: Iaec250bc07f2099a09a4b8831c59abe6ce34062c

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-vpnaas (master)

Reviewed: https://review.openstack.org/239568
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=7675d924ab038d284a64419f566a0c7c950f8733
Submitter: Jenkins
Branch: master

commit 7675d924ab038d284a64419f566a0c7c950f8733
Author: Cedric Brandily <email address hidden>
Date: Tue Oct 27 11:36:06 2015 +0900

    Prepare neutron "use_namespaces" option removal

    The neutron use_namespaces option is deprecated since Kilo, it's time
    remove it from neutron, neutron-*aas and devstack. This change removes
    use_namespaces option usage (without changing behavior) in
    unit/functional tests in order to prepare option removal from neutron.

    Partial-Bug: #1508188

    Depends-On: I2fbf65df1250d9f9f1656b3964ee3b6de1ef1118
    Change-Id: I84c1d3270448b1f085840d356532794974e5b31e

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0b1

This issue was fixed in the openstack/neutron 8.0.0.0b1 development milestone.

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron-fwaas 8.0.0.0b1

This issue was fixed in the openstack/neutron-fwaas 8.0.0.0b1 development milestone.

Changed in neutron:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Doug Wiegley (<email address hidden>) on branch: master
Review: https://review.openstack.org/237218
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

Need new owner to finish off the external_network_bridge option removal.

summary: - Remove deprecated use_namespaces option
+ Remove deprecated options
description: updated
Changed in neutron:
status: Fix Released → Incomplete
assignee: Cedric Brandily (cbrandily) → nobody
summary: - Remove deprecated options
+ Remove l3 deprecated options
Changed in neutron:
importance: Undecided → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for neutron because there has been no activity for 60 days.]

Changed in neutron:
status: Incomplete → Expired
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Darek Smigiel (<email address hidden>) on branch: master
Review: https://review.openstack.org/295901
Reason: garyk's patch here: https://review.openstack.org/#/c/296354/

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.