Node interface configuration should only be allowed when the node is ready
Bug #1508059 reported by
Blake Rouse
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Unassigned |
Bug Description
The configuration of interface on a node should only be allowed when the node is ready. This is because interface configuration is an administrator action and should occur before a node is acquired. Even when a node is acquire by an administrator it should not be allowed to be modified. This is to keep it in sync with storage, where if it is acquired and you make a change to the format or mount point that it will be reverted on release. Since we don't support that interaction with networking where it reverts when it is acquired, we should prevent modification of the node interfaces once it is acquired.
This affects both the API and UI.
Related branches
lp:~rbanffy/maas/1508059-node-if-config--on-ready-ui
- Blake Rouse (community): Approve
- Andres Rodriguez (community): Needs Fixing
- LaMont Jones (community): Approve
-
Diff: 996 lines (+415/-257)5 files modifiedsrc/maasserver/api/interfaces.py (+1/-1)
src/maasserver/api/tests/test_interfaces.py (+254/-234)
src/maasserver/static/js/angular/controllers/node_details_networking.js (+46/-13)
src/maasserver/static/js/angular/controllers/tests/test_node_details_networking.js (+99/-3)
src/maasserver/static/partials/node-details.html (+15/-6)
Changed in maas: | |
status: | Triaged → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Further discussions led to a second implementation that allows these changes when the node is either Ready or Broken.