Base Loader classes are private

Bug #1507423 reported by Jamie Lennox
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
keystoneauth
Fix Released
Wishlist
Jamie Lennox

Bug Description

The Base loader classes like: keystoneauth1.loading._plugins.identity.v3.FederatedBase are private. This makes it hard to make consistent V3 plugin loaders outside the repository like in keystoneauth-saml2. Regardless of whether this repo is ever merged back into keystoneauth this is something we want to support.

Changed in keystoneauth:
assignee: nobody → Jamie Lennox (jamielennox)
status: New → In Progress
Dolph Mathews (dolph)
Changed in keystoneauth:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystoneauth (master)

Reviewed: https://review.openstack.org/236765
Committed: https://git.openstack.org/cgit/openstack/keystoneauth/commit/?id=72f225eaf4ab3df4cd482d4bb17610c66f1524fc
Submitter: Jenkins
Branch: master

commit 72f225eaf4ab3df4cd482d4bb17610c66f1524fc
Author: Jamie Lennox <email address hidden>
Date: Mon Oct 19 12:32:44 2015 +1100

    Make public the base loader classes

    The loaders are a companion part to the authentication plugins that
    assist in loading a specific plugin from options supplied via a config
    file, command line arguments or other mechanisms.

    The Base loaders handle the options that are common to a specific
    identity authentication mechanism. They were added to the private
    directory in the move from keystoneclient as they are only used by the
    loaders defined in that directory and it gave us time to settle the
    interfaces.

    They are not expected to be private forever as they are expected to be
    reused by anyone that is developing identity plugins outside of the
    keystoneauth repository.

    Closes-Bug: #1507423
    Change-Id: I4b2fc321ae75e92509aacb15ac21e96880f2b20e

Changed in keystoneauth:
status: In Progress → Fix Committed
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/keystoneauth 2.0.0

This issue was fixed in openstack/keystoneauth 2.0.0 release.

Changed in keystoneauth:
milestone: none → 2.1.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.