workflow.js should be named as workflow.module.js

Bug #1507043 reported by Shaoquan Chen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Shaoquan Chen

Bug Description

According to Horizon's angular code file naming convention, a JS file that define a new angular module should be named as xxx.module.js so that it can be correctly sorted in JS file list.

Revision history for this message
Shaoquan Chen (sean-chen2) wrote :

According to Horizon's angular code file naming convention, a JS file
that defines a new angular module should be named as xxx.module.js so
that it can be correctly sorted in JS file list.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/236159

Changed in horizon:
assignee: nobody → Shaoquan Chen (sean-chen2)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/236159
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5fcb001ee7adf0ed387a1edffff54ffcb1bca96f
Submitter: Jenkins
Branch: master

commit 5fcb001ee7adf0ed387a1edffff54ffcb1bca96f
Author: Shaoquan Chen <email address hidden>
Date: Fri Oct 16 15:41:25 2015 -0700

    workflow.js should be named as workflow.module.js

    According to Horizon's angular code file naming convention, a JS file
    that defines a new angular module should be named as xxx.module.js so
    that it can be correctly sorted in JS file list.

    Change-Id: I2290907ae26b6e79a1dcdef788f89584e0698dea
    Closes-Bug: #1507043

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → Low
milestone: none → mitaka-1
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b1

This issue was fixed in the openstack/horizon 9.0.0.0b1 development milestone.

Changed in horizon:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.