WF execution is not created if input preparation of initial task fails

Bug #1506470 reported by Moshe Elisha
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
High
Nikolay Makhotkin

Bug Description

If an issue occurs on a stage where we're preparing task input data, for example, a workflow execution will not be created and the execution-create response will be different.
The first task(s) execution objects get created simultaneously with WF execution, within the same transaction
if something is wrong with preparing at least with one of those objects then entire TX rolls back

In case of a WF with two starting tasks in parallel and one is OK and the other throws an error on input preparation the whole WF execution object won't be created.
A successful start task should be saved in DB for sure (as well as WF execution), otherwise we loose all tracking information

This can be reproduced with the following WF:

---
version: '2.0'

fail_on_initial:
  type: direct
  tasks:
    iniitial_task:
      action: std.echo output=<% $.non_existing_yaql_method() %>

Moshe Elisha (melisha)
description: updated
Changed in mistral:
milestone: none → mitaka-1
importance: Undecided → High
status: New → Triaged
Changed in mistral:
assignee: nobody → Nikolay Makhotkin (nmakhotkin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.openstack.org/239638

Changed in mistral:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.openstack.org/239638
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=e0c00aa51634d84bed5a3bdbe07339bafc56979f
Submitter: Jenkins
Branch: master

commit e0c00aa51634d84bed5a3bdbe07339bafc56979f
Author: Nikolay Mahotkin <email address hidden>
Date: Tue Oct 27 13:23:25 2015 +0300

    Fixing wf execution creation at initial stage

     * Wf execution is not created when first
       task(s) failed.
     * Fixed some unit-tests.

    Closes-Bug: #1506470

    Change-Id: Id34b11efe15fcff0a9360e2966d1a85c29325c62

Changed in mistral:
status: In Progress → Fix Committed
tags: added: liberty-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/246838

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/liberty)

Reviewed: https://review.openstack.org/246838
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=b8e1f95acd26c5043a164d17889e731692bbf7b1
Submitter: Jenkins
Branch: stable/liberty

commit b8e1f95acd26c5043a164d17889e731692bbf7b1
Author: Nikolay Mahotkin <email address hidden>
Date: Tue Oct 27 13:23:25 2015 +0300

    Fixing wf execution creation at initial stage

     * Wf execution is not created when first
       task(s) failed.
     * Fixed some unit-tests.

    Closes-Bug: #1506470

    Change-Id: Id34b11efe15fcff0a9360e2966d1a85c29325c62
    (cherry picked from commit e0c00aa51634d84bed5a3bdbe07339bafc56979f)

tags: added: in-stable-liberty
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/mistral 2.0.0.0b1

This issue was fixed in the openstack/mistral 2.0.0.0b1 development milestone.

Changed in mistral:
status: Fix Committed → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/mistral 1.0.1

This issue was fixed in the openstack/mistral 1.0.1 release.

Changed in mistral:
milestone: mitaka-1 → 2.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/mistral 1.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.